Refactor kubelet component config lenient path decoding #85945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
release-note-none
k8s-ci-robot
added
size/S
Use NewLenientSchemeAndCodec function provided in k8s.io/component-base/codec instead of private package function.
obitech
force-pushed
the
kubelet_refactor_lenient_path
branch
from
bce0e0e
to
bf92350
Compare
mattjmcnaughton
approved these changes
Dec 5, 2019
k8s-ci-robot
added
the
lgtm
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mtaufen, obitech The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
mtaufen
added
the
priority/important-soon
k8s-ci-robot
removed
the
needs-priority
|
/lgtm |
|
/remove-sig api-machinery |
k8s-ci-robot
removed
the
sig/api-machinery
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Uses the in #84129 introduced
NewLenientSchemeAndCodecsfunction defined ink8s.io/component-base/codec, instead of a private package function.Which issue(s) this PR fixes:
Ref #82924
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
/wg component-standard
/sig api-machinery
/cc @liggitt @mtaufen @stealthybox