Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

staging/publishing: temporarily disable publishing tags #86008

Merged
merged 1 commit into from Dec 6, 2019
Merged

staging/publishing: temporarily disable publishing tags #86008

merged 1 commit into from Dec 6, 2019

Conversation

nikhita
Copy link
Member

@nikhita nikhita commented Dec 6, 2019

Ref: kubernetes/publishing-bot#210 (comment)

To make sure we get enough time to test publishing of v1.17.0
(on a test repo) when it is tagged, this commit disables publishing tags.

After testing it, we'll re-enable publishing of tags.

Does this PR introduce a user-facing change?:

NONE

@nikhita
staging/publishing: temporarily disable publishing tags
2bba8da 
To make sure we get enough time to test publishing of `v1.17.0`
(on a test repo) when it is tagged, this commit disables publishing tags.

After testing it, we'll re-enable publishing of tags.
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Dec 6, 2019
@nikhita
Copy link
Member Author

nikhita commented Dec 6, 2019 •
edited

/assign @liggitt @sttts
/kind cleanup
/priority critical-urgent
since we want this merged before v1.17.0 is cut

I also did a test run with skip-tags: true in rules, to ensure that it does indeed skip publishing tags.

Relevant part of the code:

https://github.com/kubernetes/publishing-bot/blob/b1513c6d5c7dbbec57fbc1c3f3e339c24e16aba7/cmd/publishing-bot/config/rules.go#L71

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Dec 6, 2019
@nikhita nikhita mentioned this pull request Dec 6, 2019
Merged
@liggitt
Copy link
Member

liggitt commented Dec 6, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 6, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, nikhita

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nikhita
Copy link
Member Author

nikhita commented Dec 6, 2019

/retest

k8s-ci-robot added a commit that referenced this pull request Dec 6, 2019
@k8s-ci-robot
Merge pull request #86008 from nikhita/publishing-skip-tags
a380c29 
staging/publishing: temporarily disable publishing tags
@k8s-ci-robot k8s-ci-robot merged commit a380c29 into kubernetes:master Dec 6, 2019
@k8s-ci-robot k8s-ci-robot merged commit 2bba8da into kubernetes:master Dec 6, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Dec 6, 2019
@nikhita nikhita deleted the publishing-skip-tags branch December 7, 2019 03:19
@nikhita nikhita mentioned this pull request Dec 10, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dims dims Awaiting requested review from dims

@sttts sttts Awaiting requested review from sttts

Assignees

@sttts sttts

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note-none Denotes a PR that doesn't merit a release note. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nikhita @liggitt @k8s-ci-robot @sttts