Fix staticcheck failures of e2e/storage/drivers e2e/storage/testsuites #86057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
area/test
sig/storage
neolit123
reviewed
Dec 9, 2019
| @@ -191,12 +191,17 @@ func (t *volumeLimitsTestSuite) DefineTests(driver TestDriver, pattern testpatte | |||
| e2epod.SetAffinity(&selection, nodeName) | |||
| pod.Spec.Affinity = selection.Affinity | |||
| l.unschedulablePod, err = l.cs.CoreV1().Pods(l.ns.Name).Create(pod) | |||
| framework.ExpectNoError(err) | |||
There was a problem hiding this comment.
could this error be annotated with what type of pod we could not create?
SataQiu
force-pushed
the
fix-staticcheck-20191209
branch
from
812c5fb
to
58626d8
Compare
|
/assign @oomichi |
SataQiu
force-pushed
the
fix-staticcheck-20191209
branch
from
58626d8
to
3ed535a
Compare
|
/test pull-kubernetes-e2e-gce-storage-slow |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: oomichi, SataQiu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/priority backlog |
k8s-ci-robot
added
priority/backlog
|
staticcheck is failed but that seems unrelated: Let's retest /retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Fix staticcheck failures of e2e/storage/drivers e2e/storage/testsuites
Which issue(s) this PR fixes:
Ref #81657
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: