Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add kind/flake issue template #86096

Merged
merged 1 commit into from Dec 10, 2019
Merged

Add kind/flake issue template #86096

merged 1 commit into from Dec 10, 2019

Conversation

spiffxp
Copy link
Member

@spiffxp spiffxp commented Dec 10, 2019

What type of PR is this?
/kind documentation

What this PR does / why we need it:

The kind/failing-test label should only be used for tests or jobs that
are continuously failing. Today, it's being used for test failures of
any kind, which means flakes are getting under-reported for those who
search the kind/flake label.

This PR adds a new template that uses the kind/flake label to motivate
reporting test flakes. I'm updating docs on how to report test flakes and
would like to be able to point to this issue template.

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

/priority important-soon
/sig release
cc @kubernetes/ci-signal
because of CI signal
/sig contributor-experience
because issue templates
/sig testing
because flakes

@spiffxp
Add kind/flake issue template
edfef79 
Update wording to suggest job or test as the target
@k8s-ci-robot
Copy link
Contributor

@spiffxp: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. sig/release Categorizes an issue or PR as relevant to SIG Release. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Dec 10, 2019
@spiffxp
Copy link
Member Author

spiffxp commented Dec 10, 2019

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 10, 2019
mrbobbytables
mrbobbytables reviewed Dec 10, 2019
View reviewed changes
Copy link
Member

@mrbobbytables mrbobbytables left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even if folks do continue to use the failing test template for flakes, this should still help categorize more of them with less initial triage needed. 👍

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 10, 2019
@spiffxp
Copy link
Member Author

spiffxp commented Dec 10, 2019

/retest

@spiffxp
Copy link
Member Author

spiffxp commented Dec 10, 2019

/assign @cblecker
for the /approve

@cblecker
Copy link
Member

/approve

It's a copy/paste of an existing template, meant to help categorize things. I don't think we need a consensus on this one.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 10, 2019
@spiffxp
Copy link
Member Author

spiffxp commented Dec 10, 2019

/retest

@k8s-ci-robot k8s-ci-robot merged commit 414c838 into kubernetes:master Dec 10, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Dec 10, 2019
@spiffxp spiffxp deleted the add-flake-issue-template branch December 10, 2019 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrbobbytables mrbobbytables mrbobbytables left review comments

@parispittman parispittman Awaiting requested review from parispittman

Assignees

@cblecker cblecker

@mrbobbytables mrbobbytables

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@spiffxp @k8s-ci-robot @cblecker @mrbobbytables