Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added alejandrox1 to test/approvers #86136

Merged
merged 1 commit into from Dec 11, 2019
Merged

Added alejandrox1 to test/approvers #86136

merged 1 commit into from Dec 11, 2019

Conversation

alejandrox1
Copy link
Contributor

Signed-off-by: alejandrox1 alarcj137@gmail.com

What type of PR is this?
/kind cleanup

Does this PR introduce a user-facing change?:

NONE

@alejandrox1
Added alejandrox1 to test/approvers
c051fc2 
Signed-off-by: alejandrox1 <alarcj137@gmail.com>
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Dec 10, 2019
@alejandrox1
Copy link
Contributor Author

/assign @timothysc

@alejandrox1
Copy link
Contributor Author

/priority backlog
/sig testing

@k8s-ci-robot k8s-ci-robot added priority/backlog Higher priority than priority/awaiting-more-evidence. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Dec 10, 2019
timothysc
timothysc approved these changes Dec 10, 2019
View reviewed changes
Copy link
Member

@timothysc timothysc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/hold
^ for other approvers

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 10, 2019
@timothysc timothysc mentioned this pull request Dec 11, 2019
Merged
@alejandrox1
Copy link
Contributor Author

/cc @oomichi @liggitt

@timothysc
Copy link
Member

/assign @liggitt @spiffxp @fejta

oomichi
oomichi reviewed Dec 11, 2019
View reviewed changes
Copy link
Member

@oomichi oomichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your continuous contribution @alejandrox1 !

/lgtm

@spiffxp
Copy link
Member

spiffxp commented Dec 11, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alejandrox1, spiffxp, timothysc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@timothysc
Copy link
Member

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 11, 2019
@k8s-ci-robot k8s-ci-robot merged commit 2f66bcf into kubernetes:master Dec 11, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Dec 11, 2019
@alejandrox1 alejandrox1 deleted the add-alejandrox1-as-approver branch December 11, 2019 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oomichi oomichi oomichi left review comments

@timothysc timothysc timothysc approved these changes

@draveness draveness Awaiting requested review from draveness

@neolit123 neolit123 Awaiting requested review from neolit123

@liggitt liggitt Awaiting requested review from liggitt

Assignees

@spiffxp spiffxp

@timothysc timothysc

@fejta fejta

@liggitt liggitt

@oomichi oomichi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note-none Denotes a PR that doesn't merit a release note. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@alejandrox1 @timothysc @spiffxp @k8s-ci-robot @oomichi @fejta @liggitt