e2e: move funs of framework/statefulset to e2e/apps & e2e/upgrades #86169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
|
/test pull-kubernetes-e2e-gce |
SataQiu
reviewed
Dec 12, 2019
test/e2e/apps/statefulset.go
Outdated
| @@ -52,8 +53,27 @@ const ( | |||
|
|
|||
| // Timeout for reads from databases running on stateful pods. | |||
| readTimeout = 60 * time.Second | |||
|
|
|||
| // StatefulSetPoll is a poll interval for StatefulSet tests | |||
| StatefulSetPoll = 10 * time.Second | |||
There was a problem hiding this comment.
Thanks @clarklee92
Small nits. Others lgtm.
Do these variables have to be exported？
If it is not referenced by other packages, we can set it to private.
test/e2e/apps/statefulset.go
Outdated
| // StatefulSetPoll is a poll interval for StatefulSet tests | ||
| StatefulSetPoll = 10 * time.Second | ||
| // StatefulSetTimeout is a timeout interval for StatefulSet operations | ||
| StatefulSetTimeout = 10 * time.Minute |
test/e2e/apps/statefulset.go
Outdated
| // StatefulSetTimeout is a timeout interval for StatefulSet operations | ||
| StatefulSetTimeout = 10 * time.Minute | ||
| // StatefulPodTimeout is a timeout for stateful pods to change state | ||
| StatefulPodTimeout = 5 * time.Minute |
test/e2e/apps/wait.go
Outdated
| // a RollingUpdateStatefulSetStrategyType with a non-nil RollingUpdate and Partition. All Pods with ordinals less | ||
| // than or equal to the Partition are expected to be at set's current revision. All other Pods are expected to be | ||
| // at its update revision. | ||
| func WaitForPartitionedRollingUpdate(c clientset.Interface, set *appsv1.StatefulSet) (*appsv1.StatefulSet, *v1.PodList) { |
There was a problem hiding this comment.
Do these funs have to be exported？
If it is not referenced by other packages, we can set it to private.
test/e2e/apps/wait.go
Outdated
|
|
||
| // WaitForStatus waits for the StatefulSetStatus's ObservedGeneration to be greater than or equal to set's Generation. | ||
| // The returned StatefulSet contains such a StatefulSetStatus | ||
| func WaitForStatus(c clientset.Interface, set *appsv1.StatefulSet) *appsv1.StatefulSet { |
test/e2e/apps/wait.go
Outdated
| } | ||
|
|
||
| // WaitForPodNotReady waits for the Pod named podName in set to exist and to not have a Ready condition. | ||
| func WaitForPodNotReady(c clientset.Interface, set *appsv1.StatefulSet, podName string) (*appsv1.StatefulSet, *v1.PodList) { |
test/e2e/apps/wait.go
Outdated
|
|
||
| // WaitForRollingUpdate waits for all Pods in set to exist and have the correct revision and for the RollingUpdate to | ||
| // complete. set must have a RollingUpdateStatefulSetStrategyType. | ||
| func WaitForRollingUpdate(c clientset.Interface, set *appsv1.StatefulSet) (*appsv1.StatefulSet, *v1.PodList) { |
test/e2e/apps/wait.go
Outdated
| } | ||
|
|
||
| // WaitForRunningAndNotReady waits for numStatefulPods in ss to be Running and not Ready. | ||
| func WaitForRunningAndNotReady(c clientset.Interface, numStatefulPods int32, ss *appsv1.StatefulSet) { |
There was a problem hiding this comment.
Updated, but I thought it might be used externally in the future.
clarklee92
force-pushed
the
move-e2e/framework/statefulset
branch
from
f04f416
to
5296372
Compare
|
/test pull-kubernetes-e2e-gce-100-performance |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
oomichi
reviewed
Dec 13, 2019
| @@ -18,6 +18,7 @@ package upgrades | |||
|
|
|||
| import ( | |||
| "github.com/onsi/ginkgo" | |||
| metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" | |||
There was a problem hiding this comment.
This should be moved to line 24 as the same import group.
| import ( | ||
| appsv1 "k8s.io/api/apps/v1" | ||
| v1 "k8s.io/api/core/v1" | ||
| clientset "k8s.io/client-go/kubernetes" |
There was a problem hiding this comment.
nit: need a blank line between imports of other repos and imports of k/k repo.
There was a problem hiding this comment.
Yep, I am going to turn down go importer in my IDE 🤣.
Thank you for your careful review.
Signed-off-by: clarklee92 <clarklee1992@hotmail.com>
clarklee92
force-pushed
the
move-e2e/framework/statefulset
branch
from
5296372
to
623c4f9
Compare
k8s-ci-robot
removed
the
lgtm
|
/test pull-kubernetes-node-e2e-containerd |
oomichi
reviewed
Dec 16, 2019
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: clarklee92, oomichi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/kind cleanup |
k8s-ci-robot
added
kind/cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: clarklee92 clarklee1992@hotmail.com
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
e2e: move funs of framework/statefulset to e2e/apps & e2e/upgrades
Which issue(s) this PR fixes:
Ref #86052
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: