Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrap InterPodAffinity predicate metadata as a Prefilter #86175

Merged
merged 1 commit into from Dec 13, 2019
Merged

Wrap InterPodAffinity predicate metadata as a Prefilter #86175

merged 1 commit into from Dec 13, 2019

Conversation

ahg-g
Copy link
Member

@ahg-g ahg-g commented Dec 11, 2019

What type of PR is this?

/kind feature

What this PR does / why we need it:

Wraps Inter-pod affinity predicate metadata as a PreFilter. Actually moving the code will be done after the predicate itself is moved as a Filter.

Which issue(s) this PR fixes:
Part of #85926

Does this PR introduce a user-facing change?:

NONE

/cc @Huang-Wei

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Dec 11, 2019
@ahg-g
Copy link
Member Author

ahg-g commented Dec 11, 2019

/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Dec 11, 2019
@ahg-g ahg-g force-pushed the ahg1-prefilters branch 2 times, most recently from c7ef56f to 12d20bc Compare December 11, 2019 20:58
@ahg-g
Copy link
Member Author

ahg-g commented Dec 11, 2019

/cc @alculquicondor

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Dec 11, 2019
Huang-Wei
Huang-Wei reviewed Dec 11, 2019
View reviewed changes
Copy link
Member

@Huang-Wei Huang-Wei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ahg-g ! Just some nits, otherwise LGTM.

pkg/scheduler/framework/plugins/interpodaffinity/interpod_affinity.go Show resolved Hide resolved
pkg/scheduler/framework/plugins/interpodaffinity/interpod_affinity.go Outdated Show resolved Hide resolved
pkg/scheduler/framework/plugins/interpodaffinity/interpod_affinity.go Outdated Show resolved Hide resolved
pkg/scheduler/framework/plugins/interpodaffinity/interpod_affinity.go Outdated Show resolved Hide resolved
pkg/scheduler/framework/plugins/interpodaffinity/interpod_affinity.go Outdated Show resolved Hide resolved
pkg/scheduler/framework/plugins/interpodaffinity/interpod_affinity.go Outdated Show resolved Hide resolved
pkg/scheduler/algorithm/predicates/predicates.go Show resolved Hide resolved
pkg/scheduler/algorithm/predicates/predicates_test.go Show resolved Hide resolved
ahg-g
ahg-g commented Dec 12, 2019
View reviewed changes
pkg/scheduler/algorithm/predicates/metadata_test.go Show resolved Hide resolved
pkg/scheduler/algorithm/predicates/predicates_test.go Show resolved Hide resolved
pkg/scheduler/algorithm/predicates/predicates.go Show resolved Hide resolved
pkg/scheduler/framework/plugins/interpodaffinity/interpod_affinity.go Outdated Show resolved Hide resolved
pkg/scheduler/framework/plugins/interpodaffinity/interpod_affinity.go Outdated Show resolved Hide resolved
pkg/scheduler/framework/plugins/interpodaffinity/interpod_affinity.go Outdated Show resolved Hide resolved
pkg/scheduler/framework/plugins/interpodaffinity/interpod_affinity.go Outdated Show resolved Hide resolved
pkg/scheduler/framework/plugins/interpodaffinity/interpod_affinity.go Outdated Show resolved Hide resolved
pkg/scheduler/framework/plugins/interpodaffinity/interpod_affinity.go Outdated Show resolved Hide resolved
pkg/scheduler/framework/plugins/interpodaffinity/interpod_affinity.go Show resolved Hide resolved
@ahg-g
Copy link
Member Author

ahg-g commented Dec 12, 2019

/retest

@Huang-Wei Huang-Wei mentioned this pull request Dec 12, 2019
Merged
@Huang-Wei
Copy link
Member

@ahg-g commits are good to be squashed.

@alculquicondor
Copy link
Member

/hold

I'm finish up my review soon 😅

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 12, 2019
alculquicondor
alculquicondor reviewed Dec 12, 2019
View reviewed changes
pkg/scheduler/algorithm/predicates/metadata.go Outdated Show resolved Hide resolved
pkg/scheduler/algorithm/predicates/metadata.go Outdated Show resolved Hide resolved
pkg/scheduler/algorithm/predicates/metadata_test.go Outdated
},
}

if !reflect.DeepEqual(source.Clone(), source) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prefer cmp.Equal.
Maybe we should also check that they are different objects.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can't now because we are comparing unexported members.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True...

Maybe we should also check that they are different objects

Still holds

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

pkg/scheduler/algorithm/predicates/predicates.go Outdated Show resolved Hide resolved
pkg/scheduler/framework/plugins/interpodaffinity/interpod_affinity.go Outdated Show resolved Hide resolved
pkg/scheduler/algorithm/predicates/predicates.go Show resolved Hide resolved
pkg/scheduler/framework/plugins/interpodaffinity/interpod_affinity.go Show resolved Hide resolved
ahg-g
ahg-g commented Dec 12, 2019
View reviewed changes
Copy link
Member Author

@ahg-g ahg-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

I'm finish up my review soon

thanks, I replied

alculquicondor
alculquicondor reviewed Dec 12, 2019
View reviewed changes
Copy link
Member

@alculquicondor alculquicondor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 12, 2019
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 12, 2019
@k8s-ci-robot k8s-ci-robot merged commit 6715e35 into kubernetes:master Dec 13, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Dec 13, 2019
@ahg-g ahg-g deleted the ahg1-prefilters branch January 10, 2020 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alculquicondor alculquicondor alculquicondor left review comments

@Huang-Wei Huang-Wei Huang-Wei left review comments

@draveness draveness draveness left review comments

Assignees

@alculquicondor alculquicondor

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ahg-g @k8s-ci-robot @Huang-Wei @alculquicondor @draveness