Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #86320: Add UID precondition to kubelet pod status patch updates #86324

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Dec 16, 2019

Cherry pick of #86320 on release-1.15.

#86320: Add UID precondition to kubelet pod status patch updates

For details on the cherry pick process, see the cherry pick requests page.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Dec 16, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.15 milestone Dec 16, 2019
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Dec 16, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 16, 2019
@liggitt
Copy link
Member Author

liggitt commented Dec 16, 2019

/kind bug
/priority critical-urgent
/assign @wongma7
/sig node

/hold for soaking the fix in master, xref #82387 (comment)

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 16, 2019
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Dec 16, 2019
@wongma7
Copy link
Contributor

wongma7 commented Dec 16, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 16, 2019
@mattjmcnaughton
Copy link
Contributor

/kind bug
/priority critical-urgent
/assign @wongma7
/sig node

/hold for soaking the fix in master, xref #82387 (comment)

Non-pressing question for my own learning :) What does it mean to "soak the fix" in master?

/test pull-kubernetes-node-e2e
/test pull-kubernetes-kubemark-e2e-gce-big

@liggitt
Copy link
Member Author

liggitt commented Dec 17, 2019

Non-pressing question for my own learning :) What does it mean to "soak the fix" in master?

That means letting it accumulate repeated test runs to make sure the intermittent flake it was addressing is resolved.

@mattjmcnaughton
Copy link
Contributor

mattjmcnaughton commented Dec 18, 2019 via email

@liggitt
Copy link
Member Author

liggitt commented Dec 20, 2019

/hold cancel

testgrid on master looks good

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 20, 2019
@feiskyer feiskyer removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Dec 25, 2019
@feiskyer feiskyer added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Dec 25, 2019
@k8s-ci-robot k8s-ci-robot merged commit f49ac14 into kubernetes:release-1.15 Dec 25, 2019
@k8s-ci-robot
Copy link
Contributor

@liggitt: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-gce 935ad5d link /test pull-kubernetes-e2e-gce

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@liggitt liggitt deleted the automated-cherry-pick-of-#86320-upstream-release-1.15 branch December 26, 2019 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. sig/node Categorizes an issue or PR as relevant to SIG Node. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants