New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automated cherry pick of #86320: Add UID precondition to kubelet pod status patch updates #86324
Automated cherry pick of #86320: Add UID precondition to kubelet pod status patch updates #86324
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/kind bug /hold for soaking the fix in master, xref #82387 (comment) |
/lgtm |
Non-pressing question for my own learning :) What does it mean to "soak the fix" in master? /test pull-kubernetes-node-e2e |
That means letting it accumulate repeated test runs to make sure the intermittent flake it was addressing is resolved. |
On Tue, Dec 17, 2019 at 05:47:02AM -0800, Jordan Liggitt wrote:
> Non-pressing question for my own learning :) What does it mean to "soak the fix" in master?
That means letting it accumulate repeated test runs to make sure the intermittent flake it was addressing is resolved.
--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
#86324 (comment)
Gotcha, thanks!
|
/hold cancel testgrid on master looks good |
@liggitt: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Cherry pick of #86320 on release-1.15.
#86320: Add UID precondition to kubelet pod status patch updates
For details on the cherry pick process, see the cherry pick requests page.