Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add single-item list/watch to delegated authentication reader role #86362

Merged
merged 1 commit into from Dec 25, 2019
Merged

Add single-item list/watch to delegated authentication reader role #86362

merged 1 commit into from Dec 25, 2019

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Dec 17, 2019 •
edited

cherrypick of #85375

What type of PR is this?
/kind bug

What this PR does / why we need it:
Adds single-item list/watch permission to the delegated authentication reader role

Which issue(s) this PR fixes:
Fixes #85374

https://github.com/kubernetes/kubernetes/pull/85004/files#diff-5ea42d528d6fd9e42e6a4f44359343bcR83 switched to a list/watch, but did not add required permissions to the authentication reader role.

Does this PR introduce a user-facing change?:

NONE

/sig auth
/assign @liggitt

@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Dec 17, 2019
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. sig/auth Categorizes an issue or PR as relevant to SIG Auth. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Dec 17, 2019
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 17, 2019
@liggitt
Copy link
Member

liggitt commented Dec 17, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 17, 2019
@deads2k deads2k mentioned this pull request Dec 17, 2019
Closed
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 18, 2019
@deads2k
Copy link
Contributor Author

deads2k commented Dec 18, 2019

/retest

@feiskyer feiskyer added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Dec 25, 2019
@k8s-ci-robot k8s-ci-robot merged commit 3c41818 into kubernetes:release-1.16 Dec 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jianhuiz jianhuiz Awaiting requested review from jianhuiz

@sttts sttts Awaiting requested review from sttts

Assignees

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note-none Denotes a PR that doesn't merit a release note. sig/auth Categorizes an issue or PR as relevant to SIG Auth. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.16
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@deads2k @liggitt @k8s-ci-robot @feiskyer