Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use e2eskipper package in test/e2e/common/ #87270

Merged
merged 1 commit into from Jan 22, 2020
Merged

Use e2eskipper package in test/e2e/common/ #87270

merged 1 commit into from Jan 22, 2020

Conversation

YuikoTakada
Copy link
Contributor

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
This PR use e2eskipper package instead of using func Skip* in kubernetes/test/e2e/common/

Which issue(s) this PR fixes:

Ref: #87047

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jan 16, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @YuikoTakada. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 16, 2020
@k8s-ci-robot k8s-ci-robot added area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 16, 2020
tanjunchen
tanjunchen reviewed Jan 16, 2020
View reviewed changes
test/e2e/common/secrets.go Outdated
@@ -27,6 +27,7 @@ import (
imageutils "k8s.io/kubernetes/test/utils/image"

"encoding/base64"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
one nit:
newline?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, done.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 16, 2020
@tanjunchen
Copy link
Member

tanjunchen commented Jan 16, 2020 •
edited

/ok-to-test
/assign @SataQiu
/assign @oomichi

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 16, 2020
@oomichi oomichi mentioned this pull request Jan 16, 2020
Closed
15 tasks
@oomichi
Copy link
Member

oomichi commented Jan 17, 2020

We need to run ./hack/update-gofmt.sh and apply the diff into this PR for passing pull-kubernetes-verify job.

@tanjunchen tanjunchen mentioned this pull request Jan 19, 2020
Merged
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 20, 2020
@YuikoTakada
Copy link
Contributor Author

@oomichi thanks. done

@YuikoTakada YuikoTakada deleted the move_skip_e2e_common branch January 20, 2020 07:58
@YuikoTakada
Copy link
Contributor Author

sorry, I closed PR by mistake with git push -d origin move_skip_e2e_common . what should I do?

@YuikoTakada
Copy link
Contributor Author

/reopen

@k8s-ci-robot
Copy link
Contributor

@YuikoTakada: Failed to re-open PR: state cannot be changed. The move_skip_e2e_common branch was force-pushed or recreated.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@YuikoTakada
Copy link
Contributor Author

/reopen

@k8s-ci-robot k8s-ci-robot reopened this Jan 20, 2020
@k8s-ci-robot
Copy link
Contributor

@YuikoTakada: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@oomichi
Copy link
Member

oomichi commented Jan 20, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 20, 2020
@oomichi
Copy link
Member

oomichi commented Jan 20, 2020

/test pull-kubernetes-e2e-gce

@tanjunchen
Copy link
Member

/lgtm

@tanjunchen
Copy link
Member

/assign @fejta

@oomichi
Copy link
Member

oomichi commented Jan 21, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oomichi, YuikoTakada

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 21, 2020
@k8s-ci-robot k8s-ci-robot merged commit 93e540b into kubernetes:master Jan 22, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Jan 22, 2020
This was referenced Jan 22, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanjunchen tanjunchen tanjunchen left review comments

@feiskyer feiskyer Awaiting requested review from feiskyer

@Random-Liu Random-Liu Awaiting requested review from Random-Liu

Assignees

@fejta fejta

@oomichi oomichi

@SataQiu SataQiu

@tanjunchen tanjunchen

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@YuikoTakada @k8s-ci-robot @tanjunchen @oomichi @fejta @SataQiu