Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Self nominate aojea as sig-network-reviewer #87356

Merged
merged 1 commit into from Jan 24, 2020
Merged

Self nominate aojea as sig-network-reviewer #87356

merged 1 commit into from Jan 24, 2020

Conversation

aojea
Copy link
Member

@aojea aojea commented Jan 18, 2020

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind api-change
/kind bug
/kind cleanup
/kind deprecation
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

What started as a hobby to spend a few hours on weekends has become a passion 😄
Now that IPv6 and dual-stack are taking off, and I'm more familiar with the networking code base of k/k, I'd like to continue helping.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jan 18, 2020
@aojea
Copy link
Member Author

aojea commented Jan 18, 2020

/assign @thockin @liggitt @BenTheElder

@neolit123
Copy link
Member

👍
/sig network

@k8s-ci-robot k8s-ci-robot added sig/network Categorizes an issue or PR as relevant to SIG Network. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 19, 2020
@SataQiu
Copy link
Member

SataQiu commented Jan 20, 2020

/test pull-kubernetes-e2e-gce

@liggitt
Copy link
Member

liggitt commented Jan 20, 2020

sgtm, will route to network folks for lgtm
/cc @thockin @danwinship

@liggitt liggitt removed their assignment Jan 20, 2020
@liggitt liggitt removed their request for review January 20, 2020 13:20
@danwinship
Copy link
Contributor

/lgtm !

@danwinship
Copy link
Contributor

danwinship commented Jan 21, 2020 •
edited

(though if you wanted to alphabetize the group while you're there...)

@danwinship
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 21, 2020
@thockin
Copy link
Member

thockin commented Jan 21, 2020 via email

@aojea
Copy link
Member Author

aojea commented Jan 21, 2020

/retest

@BenTheElder
Copy link
Member

/priority important-longterm
/kind cleanup

@k8s-ci-robot k8s-ci-robot added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Jan 22, 2020
@BenTheElder
Copy link
Member

@thockin @liggitt anyone want to /approve? 🙃
/lgtm

@liggitt
Copy link
Member

liggitt commented Jan 23, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 23, 2020
@aojea
Copy link
Member Author

aojea commented Jan 23, 2020

/retest

1 similar comment
@aojea
Copy link
Member Author

aojea commented Jan 23, 2020

/retest

@k8s-ci-robot k8s-ci-robot merged commit 88a0574 into kubernetes:master Jan 24, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Jan 24, 2020
@aojea
Copy link
Member Author

aojea commented Jan 24, 2020

Thanks all 😄

@aojea aojea mentioned this pull request Mar 23, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@danwinship danwinship Awaiting requested review from danwinship

@thockin thockin Awaiting requested review from thockin

Assignees

@danwinship danwinship

@BenTheElder BenTheElder

@thockin thockin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note-none Denotes a PR that doesn't merit a release note. sig/network Categorizes an issue or PR as relevant to SIG Network. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@aojea @neolit123 @SataQiu @liggitt @danwinship @thockin @BenTheElder @k8s-ci-robot