Staticcheck: vendor/k8s.io/kubectl/pkg/cmd/set and .../edit #87405

gavinfish · 2020-01-21T03:23:09Z

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Fix static check failures for:

vendor/k8s.io/kubectl/pkg/cmd/set
vendor/k8s.io/kubectl/pkg/cmd/edit

Ref #81657

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

None

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

None

k8s-ci-robot · 2020-01-21T03:23:18Z

Hi @gavinfish. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

gavinfish · 2020-01-21T03:24:45Z

/assign @soltysh

ash2k · 2020-01-21T05:12:23Z

/ok-to-test

gavinfish · 2020-01-21T06:46:10Z

/retest

gavinfish · 2020-01-21T12:59:32Z

/retest

soltysh · 2020-02-28T20:43:04Z

staging/src/k8s.io/kubectl/pkg/cmd/set/helper.go

@@ -69,7 +70,7 @@ func selectString(s, spec string) bool {
 		// last part does not exactly match remaining part of string
 		case i == (len(parts)-1) && len(s) != (len(part)+next):
 			match = false
-			break
+			break Loop


Why is this needed, this works just fine and is only needed when two or more loops is in effect.

There is no need to add a break in switch cases for go. I think the logic here is to skip the for loop once the match variable is set as false.

soltysh · 2020-02-28T20:43:52Z

staging/src/k8s.io/kubectl/pkg/cmd/set/set_selector.go

@@ -164,6 +164,9 @@ func (o *SetSelectorOptions) RunSelector() error {
 	r := o.ResourceFinder.Do()

 	return r.Visit(func(info *resource.Info, err error) error {
+		if err != nil {


This might change behaviour, since we'll break earlier can you double check that?

Agree. But I think precheck here makes sense. Similar logic at reconcile

kubernetes/pkg/kubectl/cmd/auth/reconcile.go

Lines 192 to 197 in 5488fe5

// RunReconcile performs the execution

func (o *ReconcileOptions) RunReconcile() error {

return o.Visitor.Visit(func(info *resource.Info, err error) error {

if err != nil {

return err

}

gavinfish · 2020-03-22T07:54:06Z

PTAL @soltysh

soltysh · 2020-04-22T13:52:15Z

/lgtm
/approve

k8s-ci-robot · 2020-04-22T13:54:58Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gavinfish, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~hack/OWNERS~~ [soltysh]
~~staging/src/k8s.io/kubectl/OWNERS~~ [soltysh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

fejta-bot · 2020-04-22T17:57:18Z

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

fejta-bot · 2020-04-22T21:45:11Z

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

fejta-bot · 2020-04-23T00:33:11Z

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

gavinfish · 2020-04-23T01:44:05Z

/test pull-kubernetes-e2e-kind

k8s-ci-robot · 2020-04-23T03:44:38Z

@gavinfish: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
pull-kubernetes-verify	`2b8e60b`	link	`/test pull-kubernetes-verify`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

fejta-bot · 2020-04-23T06:09:13Z

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

k8s-ci-robot assigned soltysh Jan 21, 2020

k8s-ci-robot added area/kubectl sig/cli Categorizes an issue or PR as relevant to SIG CLI. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 21, 2020

k8s-ci-robot requested review from dixudx and eparis January 21, 2020 03:25

gavinfish changed the title ~~Staticcheck: vendor/k8s.io/pkg/cmd/set and .../edit~~ Staticcheck: vendor/k8s.io/kubectl/pkg/cmd/set and .../edit Jan 21, 2020

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 21, 2020

soltysh requested changes Feb 28, 2020

View reviewed changes

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 1, 2020

Staticcheck: vendor/k8s.io/pkg/cmd/set|edit

2b8e60b

gavinfish force-pushed the kubectl_pkg_cmd_set branch from 3922189 to 2b8e60b Compare March 21, 2020 15:20

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 21, 2020

gavinfish requested a review from soltysh March 22, 2020 07:54

soltysh approved these changes Apr 22, 2020

View reviewed changes

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 22, 2020

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 22, 2020

k8s-ci-robot merged commit 653396d into kubernetes:master Apr 23, 2020

k8s-ci-robot added this to the v1.19 milestone Apr 23, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Staticcheck: vendor/k8s.io/kubectl/pkg/cmd/set and .../edit #87405

Staticcheck: vendor/k8s.io/kubectl/pkg/cmd/set and .../edit #87405

gavinfish commented Jan 21, 2020

k8s-ci-robot commented Jan 21, 2020

gavinfish commented Jan 21, 2020

ash2k commented Jan 21, 2020

gavinfish commented Jan 21, 2020

gavinfish commented Jan 21, 2020

soltysh Feb 28, 2020

gavinfish Feb 29, 2020

soltysh Feb 28, 2020

gavinfish Feb 29, 2020

gavinfish commented Mar 22, 2020

soltysh commented Apr 22, 2020

k8s-ci-robot commented Apr 22, 2020

fejta-bot commented Apr 22, 2020

fejta-bot commented Apr 22, 2020

fejta-bot commented Apr 23, 2020

gavinfish commented Apr 23, 2020

k8s-ci-robot commented Apr 23, 2020

fejta-bot commented Apr 23, 2020

	// RunReconcile performs the execution
	func (o *ReconcileOptions) RunReconcile() error {
	return o.Visitor.Visit(func(info *resource.Info, err error) error {
	if err != nil {
	return err
	}

Staticcheck: vendor/k8s.io/kubectl/pkg/cmd/set and .../edit #87405

Staticcheck: vendor/k8s.io/kubectl/pkg/cmd/set and .../edit #87405

Conversation

gavinfish commented Jan 21, 2020

k8s-ci-robot commented Jan 21, 2020

gavinfish commented Jan 21, 2020

ash2k commented Jan 21, 2020

gavinfish commented Jan 21, 2020

gavinfish commented Jan 21, 2020

soltysh Feb 28, 2020

Choose a reason for hiding this comment

gavinfish Feb 29, 2020

Choose a reason for hiding this comment

soltysh Feb 28, 2020

Choose a reason for hiding this comment

gavinfish Feb 29, 2020

Choose a reason for hiding this comment

gavinfish commented Mar 22, 2020

soltysh commented Apr 22, 2020

k8s-ci-robot commented Apr 22, 2020

fejta-bot commented Apr 22, 2020

fejta-bot commented Apr 22, 2020

fejta-bot commented Apr 23, 2020

gavinfish commented Apr 23, 2020

k8s-ci-robot commented Apr 23, 2020

fejta-bot commented Apr 23, 2020