Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump dependency github.com/prometheus/client_model@v0.2.0 #87517

Merged
merged 1 commit into from Jan 31, 2020
Merged

Bump dependency github.com/prometheus/client_model@v0.2.0 #87517

merged 1 commit into from Jan 31, 2020

Conversation

odinuge
Copy link
Member

@odinuge odinuge commented Jan 24, 2020

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Switch to tagged release of the library.

Changelog: prometheus/client_model@14fe0d1...v0.2.0

This lib was reverted from v0.1.0 to untagged sha 14fe0d1b01d4 here: #87081 (comment)

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/apiserver area/cloudprovider area/dependency Issues or PRs related to dependency changes area/kubectl sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 24, 2020
@k8s-ci-robot k8s-ci-robot requested review from aojea, dchen1107 and a team January 24, 2020 12:34
@odinuge
Copy link
Member Author

odinuge commented Jan 24, 2020

/assign dims liggitt

@aojea
Copy link
Member

aojea commented Jan 24, 2020

/retest

ipv6 job was a network problem

ERROR: Analysis of target '//build:docker-artifacts' failed; build aborted: no such package '@debian-base-amd64//image': Pull command failed: F0124 12:39:00.905256     899 __main__.py:133] Error pulling and saving image k8s.gcr.io/debian-base@sha256:d7be39e143d4e6677a28c81c0a84868b40800fc979dea1848bb19d526668a00c: [Errno 104] Connection reset by peer

gce one of the known flakes

[sig-storage] In-tree Volumes [Driver: gcepd] [T

@odinuge
Copy link
Member Author

odinuge commented Jan 27, 2020

/retest

@dims
Copy link
Member

dims commented Jan 27, 2020

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 27, 2020
@liggitt
Copy link
Member

liggitt commented Jan 27, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, liggitt, odinuge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 27, 2020
@odinuge
Copy link
Member Author

odinuge commented Jan 27, 2020

/retest

@odinuge
Copy link
Member Author

odinuge commented Jan 27, 2020

/test pull-kubernetes-e2e-gce

@odinuge
Copy link
Member Author

odinuge commented Jan 27, 2020

/retest

@odinuge
Copy link
Member Author

odinuge commented Jan 27, 2020

/test pull-kubernetes-e2e-gce

@odinuge
Copy link
Member Author

odinuge commented Jan 27, 2020 •
edited

/test pull-kubernetes-e2e-gce

ref. #87441

@odinuge
Copy link
Member Author

odinuge commented Jan 27, 2020

/retest

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

1 similar comment
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@odinuge
Copy link
Member Author

odinuge commented Jan 28, 2020

/retest

2 similar comments
@odinuge
Copy link
Member Author

odinuge commented Jan 28, 2020

/retest

@odinuge
Copy link
Member Author

odinuge commented Jan 28, 2020

/retest

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

7 similar comments
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

k8s-ci-robot added a commit that referenced this pull request Jan 31, 2020
@k8s-ci-robot
Merge pull request #87517 from odinuge/prom-client_model
608ac4e 
Bump dependency github.com/prometheus/client_model@v0.2.0
@k8s-ci-robot k8s-ci-robot merged commit 608ac4e into kubernetes:master Jan 31, 2020
@k8s-ci-robot k8s-ci-robot merged commit 292804a into kubernetes:master Jan 31, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Jan 31, 2020
wking pushed a commit to wking/kubernetes that referenced this pull request Jul 21, 2020
@k8s-publishing-bot
Merge pull request kubernetes#87517 from odinuge/prom-client_model
0dd665e 
Bump dependency github.com/prometheus/client_model@v0.2.0

Kubernetes-commit: 608ac4e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aojea aojea Awaiting requested review from aojea

@dchen1107 dchen1107 Awaiting requested review from dchen1107

Assignees

@dims dims

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/cloudprovider area/dependency Issues or PRs related to dependency changes area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@odinuge @aojea @dims @liggitt @k8s-ci-robot @fejta-bot