Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #87658: Enable selinux tags in make targets #87753

Merged
merged 1 commit into from Feb 21, 2020
Merged

Automated cherry pick of #87658: Enable selinux tags in make targets #87753

merged 1 commit into from Feb 21, 2020

Conversation

simonswine
Copy link
Contributor

Cherry pick of #87658 on release-1.17.

#87658: Enable selinux tags in make targets

For details on the cherry pick process, see the cherry pick requests page.

@dims @simonswine
Enable selinux tags in make targets
84dbc7f 
In 24d1059, a fix was made in bazel
based builds to ensure that we add `selinux` tag when we build all
binaries especially the `kubelet`. We need to do the same for in our
hack scripts so things like `make release` will work properly as well.

Some scripts use `GOFLAGS=-tags=providerless` for example, So we should
support the tags to be specified in GOFLAGS as well. We parse out the
tags from there and ensure selinux is added to the list of tags we used
for building the binaries. Note that we add our own `-tags` with the
full set of tags and since we specify our parameter at the end, ours
full list takes precendence
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Feb 2, 2020
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 2, 2020
@k8s-ci-robot k8s-ci-robot added area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 2, 2020
@simonswine
Copy link
Contributor Author

/test pull-kubernetes-cross

@simonswine simonswine mentioned this pull request Feb 3, 2020
Merged
@tpepper
Copy link
Member

tpepper commented Feb 3, 2020

/kind bug
/priority important-soon

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 3, 2020
@tpepper
Copy link
Member

tpepper commented Feb 3, 2020

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Feb 3, 2020
@xichengliudui
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 5, 2020
@liggitt
Copy link
Member

liggitt commented Feb 5, 2020

/hold

the only e2e tests I'm aware of around selinux functionality are still failing - see #87658

do we have verification this actually resolves the problem?

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 5, 2020
@justaugustus
Copy link
Member

Today is the cherry pick deadline for the next patch release cycle.
If you intend to get this PR into this cycle, it must be approved by the relevant owners ASAP.

@simonswine
Copy link
Contributor Author

simonswine commented Feb 7, 2020 •
edited

I would prefer to get that into the next release.

@liggitt I am running a bazel built tag of v1.16.6 successfully for a while with SELinux working. I tested this PR through running make quick-release and those are working as well. I was not aware that release uses non-bazel builds, so we have a divergence of build tags between make and bazel go build tags, which is not great. I agree it needs some proper E2E and some work is in progress there as far as I can tell

@liggitt
Copy link
Member

liggitt commented Feb 11, 2020

Would like #88008 triaged before merging this

@simonswine simonswine mentioned this pull request Feb 12, 2020
Closed
@liggitt
Copy link
Member

liggitt commented Feb 12, 2020

#88008 turned out to be a non-issue.

/hold cancel
I'll defer to sig-storage to determine whether this is sufficiently tested to pick to release branches, given the selinux tests we have are still failing and appear to be incorrect.

/assign @saad-ali @jsafrane @gnufied

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 12, 2020
@pdhung
Copy link

pdhung commented Feb 13, 2020

The PR is very needed for companies that use k8s with mandatory SELinux. We upgraded to 1.16 and now our k8s cluster won't work without disabling SELinux. IMHO it is a high priority one.

@pdhung
Copy link

pdhung commented Feb 19, 2020

As #88247 has been merged, I think this PR should be ready for approval.

@liggitt
Copy link
Member

liggitt commented Feb 19, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, simonswine

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 19, 2020
@kolyshkin
Copy link
Contributor

kolyshkin commented Feb 19, 2020 •
edited

Oops, wrong window (was: /release-note-none)

@k8s-ci-robot
Copy link
Contributor

@kolyshkin: you can only set the release note label to release-note-none if you are the PR author or an org member.

In response to this:

/release-note-none

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kolyshkin kolyshkin mentioned this pull request Feb 20, 2020
Closed
@feiskyer feiskyer added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Feb 21, 2020
@k8s-ci-robot k8s-ci-robot merged commit 50940f7 into kubernetes:release-1.17 Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenTheElder BenTheElder Awaiting requested review from BenTheElder

@xichengliudui xichengliudui Awaiting requested review from xichengliudui

Assignees

@gnufied gnufied

@jsafrane jsafrane

@saad-ali saad-ali

@xichengliudui xichengliudui

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.17
Development

Successfully merging this pull request may close these issues.

None yet