gce-addons: Make sure default/limit-range doesn't get overridden #87902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
apelisse
force-pushed
the
ensureexist-limit-range-gce
branch
from
8aad2b5
to
e41f2cc
Compare
k8s-ci-robot
added
size/XS
|
/assign @mikedanese |
|
/cc @yliaog |
k8s-ci-robot
added
the
sig/cluster-lifecycle
|
/priority important-soon |
k8s-ci-robot
added
priority/important-soon
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: apelisse, mikedanese The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/lgtm @mikedanese do you know the reason to have this limitrange for default namespace? |
|
/retest |
1 similar comment
|
/retest |
|
/retest Review the full test history for this PR. Silence the bot with an |
This was referenced Apr 9, 2020
Merged
Merged
Merged
k8s-ci-robot
added a commit
that referenced
this pull request
Apr 13, 2020
…02-upstream-release-1.15 Automated cherry pick of #87902: gce-addons: Make sure default/limit-range doesn't get
k8s-ci-robot
added a commit
that referenced
this pull request
Apr 13, 2020
…02-upstream-release-1.17 Automated cherry pick of #87902: gce-addons: Make sure default/limit-range doesn't get
k8s-ci-robot
added a commit
that referenced
this pull request
Apr 13, 2020
…02-upstream-release-1.16 Automated cherry pick of #87902: gce-addons: Make sure default/limit-range doesn't get
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On cluster update, the limit-range in the default namespace gets overridden, which can cause problems for customers.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: