Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHANGELOG/CHANGELOG-1.18.md: Fix spelling #87969

Merged
merged 1 commit into from May 12, 2020

Conversation

sanmai-NL
Copy link
Contributor

@sanmai-NL sanmai-NL commented Feb 10, 2020

What type of PR is this?
/kind documentation

What this PR does / why we need it:
Fix 'aggregation' spelling.

Which issue(s) this PR fixes:
Not applicable.

Special notes for your reviewer:
Not applicable.

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Feb 10, 2020
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 10, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @sanmai-NL!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @sanmai-NL. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 10, 2020
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 10, 2020
@sanmai-NL
Copy link
Contributor Author

/assign @justaugustus
I've signed the CLA.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Feb 10, 2020
@justaugustus
Copy link
Member

justaugustus commented Feb 12, 2020

@sanmai-NL -- Please update the PR title, description, and description commit message to describe what spelling you're fixing.

Example:

CHANGELOG/CHANGELOG-1.18.md: Fix spelling

ref: https://chris.beams.io/posts/git-commit/
/hold
/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 12, 2020
@justaugustus justaugustus added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Feb 12, 2020
@k8s-ci-robot k8s-ci-robot removed the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Feb 12, 2020
@sanmai-NL
Copy link
Contributor Author

/retest

All flakes.

@justaugustus
Copy link
Member

@sanmai-NL -- Can you address my comment before sending this for retest: #87969 (comment)

@justaugustus justaugustus removed the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Feb 14, 2020
@justaugustus justaugustus added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 14, 2020
@sanmai-NL
Copy link
Contributor Author

@justaugustus Will do. Why before?

@justaugustus
Copy link
Member

... Why before?

@sanmai-NL -- because tests cost money 😅
Not a great answer especially since this is a markdown change, but I'm just trying to encourage good submission habits.

@sanmai-NL
Copy link
Contributor Author

@justaugustus: Yeah, I figured that. Besides this only being a docs change, you only asked me to change some things that aren't altering the Git history, so tests wouldn't be re-run anyhow. May I propose you spend some time on limiting test runs to those that may be impacted by a change? This could save you CI budget if that's a limitation you're running into.

@sanmai-NL sanmai-NL changed the title Fix spelling CHANGELOG/CHANGELOG-1.18.md: Fix spelling Feb 14, 2020
@sanmai-NL
Copy link
Contributor Author

/retest

@k8s-ci-robot
Copy link
Contributor

@sanmai-NL: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sanmai-NL
Copy link
Contributor Author

@sanmai-NL: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

@justaugustus

@justaugustus
Copy link
Member

@sanmai-NL -- Can you also update the commit message? My original message was supposed to mention that as well.

@justaugustus
Copy link
Member

@sanmai-NL -- Did you have a chance to get back to this one?

@sanmai-NL
Copy link
Contributor Author

Thanks for reminding. No, been too busy. Will try to fix today! If not close the PR and let your team make the typo fixes please. 🙂

@sanmai-NL
Copy link
Contributor Author

@justaugustus: should be done now.

@justaugustus
Copy link
Member

Thanks for the fix, @sanmai-NL (and sorry for the wait)!
/ok-to-test
/lgtm
/approve
/hold cancel

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 12, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justaugustus, sanmai-NL

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 12, 2020
@sanmai-NL
Copy link
Contributor Author

/retest

1 similar comment
@sanmai-NL
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit 6b1bb5e into kubernetes:master May 12, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone May 12, 2020
@sanmai-NL sanmai-NL deleted the patch-1 branch May 12, 2020 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants