New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CHANGELOG/CHANGELOG-1.18.md: Fix spelling #87969
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @sanmai-NL! |
Hi @sanmai-NL. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @justaugustus |
@sanmai-NL -- Please update the PR title, description, and Example:
ref: https://chris.beams.io/posts/git-commit/ |
/retest All flakes. |
@sanmai-NL -- Can you address my comment before sending this for retest: #87969 (comment) |
@justaugustus Will do. Why before? |
@sanmai-NL -- because tests cost money 😅 |
@justaugustus: Yeah, I figured that. Besides this only being a docs change, you only asked me to change some things that aren't altering the Git history, so tests wouldn't be re-run anyhow. May I propose you spend some time on limiting test runs to those that may be impacted by a change? This could save you CI budget if that's a limitation you're running into. |
/retest |
@sanmai-NL: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@sanmai-NL -- Can you also update the commit message? My original message was supposed to mention that as well. |
@sanmai-NL -- Did you have a chance to get back to this one? |
Thanks for reminding. No, been too busy. Will try to fix today! If not close the PR and let your team make the typo fixes please. 🙂 |
@justaugustus: should be done now. |
Thanks for the fix, @sanmai-NL (and sorry for the wait)! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justaugustus, sanmai-NL The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
1 similar comment
/retest |
What type of PR is this?
/kind documentation
What this PR does / why we need it:
Fix 'aggregation' spelling.
Which issue(s) this PR fixes:
Not applicable.
Special notes for your reviewer:
Not applicable.
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: