Use compute v1 api to specify network tier #88487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
k8s-ci-robot
added
area/cloudprovider
sig/cloud-provider
|
/assign @cheftako |
zioproto
force-pushed
the
issues/69314-tier-config-support
branch
from
b90ea05
to
9275d19
Compare
k8s-ci-robot
added
size/L
cheftako
reviewed
Feb 24, 2020
staging/src/k8s.io/legacy-cloud-providers/gce/gce_loadbalancer_external.go
Outdated
Show resolved
Hide resolved
Drop the use of the alpha api for operations that are supported by compute v1 The switch/case logic was wrong because the user can set the default tier for a project: https://cloud.google.com/network-tiers/docs/using-network-service-tiers#setting_the_tier_for_all_resources_in_a_project The assumption that the default tier is always PREMIUM is wrong This patch uses the explicit network tier when possible, or it falls back to the project default. Signed-off-by: Saverio Proto <saverioproto@google.com>
zioproto
force-pushed
the
issues/69314-tier-config-support
branch
from
9275d19
to
bdc54eb
Compare
k8s-ci-robot
added
the
lgtm
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mikedanese, zioproto The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/cherrypick-candidate |
This was referenced Mar 6, 2020
k8s-ci-robot
added a commit
that referenced
this pull request
Nov 27, 2020
…87-upstream-release-1.17 Automated cherry pick of #88487: Use compute v1 api to specify network tier
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Drop the use of the alpha compute api for operations that are supported by compute v1.
With this change the users of GKE will be able to test the annotation
cloud.google.com/network-tier: Standardwhen creating a GKE alpha cluster, but without the need of whitelisting the project for the compute alpha api.Bonus: the switch/case logic was wrong because the user can set the default tier for a project:
https://cloud.google.com/network-tiers/docs/using-network-service-tiers#setting_the_tier_for_all_resources_in_a_project
The assumption that the default tier is always PREMIUM is wrong
This patch uses the explicit network tier when possible,
or it falls back to the project default.
Which issue(s) this PR fixes:
Fixes #69314
Does this PR introduce a user-facing change?: