Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(cleanup/scheduler): remove unused function #88626

Merged
merged 1 commit into from Feb 29, 2020
Merged

(cleanup/scheduler): remove unused function #88626

merged 1 commit into from Feb 29, 2020

Conversation

yuzhiquan
Copy link
Member

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 27, 2020
@yuzhiquan
Copy link
Member Author

/sig scheduling
/priority backlog

@k8s-ci-robot k8s-ci-robot added sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. priority/backlog Higher priority than priority/awaiting-more-evidence. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 27, 2020
@yuzhiquan
Copy link
Member Author

/assign @ahg-g

wgliang
wgliang approved these changes Feb 28, 2020
View reviewed changes
Copy link
Contributor

@wgliang wgliang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 28, 2020
@ahg-g
Copy link
Member

ahg-g commented Feb 28, 2020

This function is used to register out of tree plugins, we shouldn't remove it.

Please update the comment saying:

"// WithPlugin creates an Option based on plugin name and factory. Please don't remove this function: it is used to register out-of-tree plugins, hence there are no references to it from the kubernetes scheduler code base"

@ahg-g
Copy link
Member

ahg-g commented Feb 28, 2020

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 28, 2020
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 28, 2020
@yuzhiquan
Copy link
Member Author

This function is used to register out of tree plugins, we shouldn't remove it.

Please update the comment saying:

"// WithPlugin creates an Option based on plugin name and factory. Please don't remove this function: it is used to register out-of-tree plugins, hence there are no references to it from the kubernetes scheduler code base"

ok, update comment.
i have used this function before, but can not found more usage now, so send this pr for cleanup.

ahg-g
ahg-g reviewed Feb 28, 2020
View reviewed changes
cmd/kube-scheduler/app/server.go Outdated
func WithPlugin(name string, factory framework.PluginFactory) Option {
return func(registry framework.Registry) error {
return registry.Register(name, factory)
}
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert this, add empty line at the end

cmd/kube-scheduler/app/server.go Outdated
@@ -332,9 +332,10 @@ func getRecorderFactory(cc *schedulerserverconfig.CompletedConfig) profile.Recor
}
}

// WithPlugin creates an Option based on plugin name and factory. This function is used to register out-of-tree plugins.
// WithPlugin creates an Option based on plugin name and factory. Please don't remove this function: it is used to register out-of-tree plugins,
// hence there are no references to it from the kubernetes scheduler code base
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

end comment with a "."

@yuzhiquan
Copy link
Member Author

/kind cleanup
/test pull-kubernetes-e2e-kind

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Feb 29, 2020
@ahg-g
Copy link
Member

ahg-g commented Feb 29, 2020

/lgtm
/approve
/hold cancel

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Feb 29, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, yuzhiquan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 29, 2020
@k8s-ci-robot k8s-ci-robot merged commit 5698716 into kubernetes:master Feb 29, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Feb 29, 2020
@yuzhiquan yuzhiquan deleted the patch-clean1 branch February 29, 2020 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahg-g ahg-g ahg-g left review comments

@wgliang wgliang wgliang approved these changes

@resouer resouer Awaiting requested review from resouer

Assignees

@wgliang wgliang

@ahg-g ahg-g

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note-none Denotes a PR that doesn't merit a release note. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@yuzhiquan @ahg-g @k8s-ci-robot @wgliang