Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

validate configuration of kube-proxy IPVS tcp,tcpfin,udp timeout #88657

Merged
merged 1 commit into from Mar 2, 2020
Merged

validate configuration of kube-proxy IPVS tcp,tcpfin,udp timeout #88657

merged 1 commit into from Mar 2, 2020

Conversation

chendotjs
Copy link
Contributor

What type of PR is this?

/kind bug

What this PR does / why we need it:

kube-proxy should validate --ipvs-tcp-timeout, --ipvs-tcpfin-timeout, --ipvs-udp-timeout flag values at start.

Which issue(s) this PR fixes:

Fixes #88656

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

validate kube-proxy flags --ipvs-tcp-timeout, --ipvs-tcpfin-timeout, --ipvs-udp-timeout

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 28, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @chendotjs. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 28, 2020
@k8s-ci-robot k8s-ci-robot added sig/network Categorizes an issue or PR as relevant to SIG Network. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 28, 2020
@aojea
Copy link
Member

aojea commented Feb 29, 2020

/assign @lbernail @andrewsykim

aojea
aojea reviewed Feb 29, 2020
View reviewed changes
pkg/proxy/apis/config/validation/validation.go
@@ -283,6 +284,24 @@ func validateKubeProxyNodePortAddress(nodePortAddresses []string, fldPath *field
return allErrs
}

func validateIPVSTimeout(config kubeproxyconfig.KubeProxyIPVSConfiguration, fldPath *field.Path) field.ErrorList {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to move it to an independent function?
Seems that the conntrack timeouts are validated in the same function

config.TCPCloseWaitTimeout.Duration
config.TCPEstablishedTimeout.Duration

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it makes to have a function for this given the current way we validate the ipvs configuration

@aojea
Copy link
Member

aojea commented Feb 29, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 29, 2020
andrewsykim
andrewsykim reviewed Mar 1, 2020
View reviewed changes
pkg/proxy/apis/config/validation/validation.go Outdated
allErrs := field.ErrorList{}

if config.TCPTimeout.Duration < 0 {
allErrs = append(allErrs, field.Invalid(fldPath.Child("TCPTimeout"), config.MinSyncPeriod, "must be greater than or equal to 0"))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

config.MinSyncPeriod -> config.TCPTimeout

pkg/proxy/apis/config/validation/validation.go Outdated
}

if config.TCPFinTimeout.Duration < 0 {
allErrs = append(allErrs, field.Invalid(fldPath.Child("TCPFinTimeout"), config.MinSyncPeriod, "must be greater than or equal to 0"))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

config.MinSyncPeriod -> config.TCPFinTimeout

pkg/proxy/apis/config/validation/validation.go Outdated
}

if config.UDPTimeout.Duration < 0 {
allErrs = append(allErrs, field.Invalid(fldPath.Child("UDPTimeout"), config.MinSyncPeriod, "must be greater than or equal to 0"))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

config.MinSyncPeriod -> config.UDPTimeout

@lbernail
Copy link
Contributor

lbernail commented Mar 1, 2020

Thanks @chendotjs !
Once the small typos mentioned by @andrewsykim are addressed we'll lgtm

@chendotjs
Copy link
Contributor Author

Thanks @aojea for review.
😅Typos are fixed, please take another look. @lbernail @andrewsykim

andrewsykim
andrewsykim reviewed Mar 2, 2020
View reviewed changes
Copy link
Member

@andrewsykim andrewsykim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/priority important-soon

/assign @thockin

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 2, 2020
thockin
thockin reviewed Mar 2, 2020
View reviewed changes
Copy link
Member

@thockin thockin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chendotjs, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 2, 2020
@k8s-ci-robot k8s-ci-robot merged commit 0159314 into kubernetes:master Mar 2, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Mar 2, 2020
@chendotjs chendotjs deleted the validate-ipvs-timeout branch March 3, 2020 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbernail lbernail lbernail left review comments

@thockin thockin thockin left review comments

@aojea aojea aojea left review comments

@andrewsykim andrewsykim andrewsykim left review comments

@danwinship danwinship Awaiting requested review from danwinship

@dcbw dcbw Awaiting requested review from dcbw

Assignees

@lbernail lbernail

@thockin thockin

@andrewsykim andrewsykim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/network Categorizes an issue or PR as relevant to SIG Network. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.

kube-proxy doesn't validate IPVS tcp, tcpfin and udp timeouts
6 participants
@chendotjs @k8s-ci-robot @aojea @lbernail @thockin @andrewsykim