Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix block snapshot tests #88727

Merged
merged 2 commits into from Mar 2, 2020
Merged

Fix block snapshot tests #88727

merged 2 commits into from Mar 2, 2020

Conversation

jsafrane
Copy link
Member

@jsafrane jsafrane commented Mar 2, 2020 •
edited

Use InjectContent / TestVolumeClient to test a snapshot volume, since these functions support raw block volumes.

/kind failing-test
Fixes #88726 #88707

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@jsafrane
Fix block snapshot tests
104db4f 
Use InjectContent / TestVolumeClient to test a snapshot volume, since these
functions support raw block volumes.
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 2, 2020
@jsafrane
Copy link
Member Author

jsafrane commented Mar 2, 2020

/hold
Needs https://github.com/kubernetes-csi/csi-driver-host-path/pull/162/files merged and released first.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 2, 2020
@jsafrane
Copy link
Member Author

jsafrane commented Mar 2, 2020

/priority important-soon
/sig storage
@msau42 @xing-yang @pohly, PTAL

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 2, 2020
@jsafrane jsafrane mentioned this pull request Mar 2, 2020
Closed
@k8s-ci-robot k8s-ci-robot added area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Mar 2, 2020
@xing-yang
Copy link
Contributor

LGTM

@jsafrane
Copy link
Member Author

jsafrane commented Mar 2, 2020

Added csi-driver-host-path with fixed block snapshots.
/hold cancel
/test pull-kubernetes-e2e-gce-alpha-features

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 2, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@msau42
Copy link
Member

msau42 commented Mar 2, 2020

/lgtm
Hm we're supposed to have pull-kubernetes-e2e-gce-storage-snapshot job to test snapshots in non alpha clusters but it appears to not be running any tests? @xing-yang can you help look into this?

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 2, 2020
@xing-yang
Copy link
Contributor

@msau42 sure, I'll take a look.

@xing-yang
Copy link
Contributor

/test pull-kubernetes-e2e-kind-ipv6

@xing-yang
Copy link
Contributor

/lgtm

@jsafrane jsafrane mentioned this pull request Mar 2, 2020
Merged
@k8s-ci-robot k8s-ci-robot merged commit 24bf9e0 into kubernetes:master Mar 2, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Mar 2, 2020
@droslean droslean mentioned this pull request Mar 2, 2020
Closed
@jsafrane jsafrane mentioned this pull request Mar 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidz627 davidz627 Awaiting requested review from davidz627

@jingxu97 jingxu97 Awaiting requested review from jingxu97

Assignees

@xing-yang xing-yang

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.

Snapshot tests fail with block volumes
4 participants
@jsafrane @xing-yang @k8s-ci-robot @msau42