Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support TLS Server Name overrides in kubeconfig file #88769

Merged
merged 2 commits into from Mar 4, 2020
Merged

Support TLS Server Name overrides in kubeconfig file #88769

merged 2 commits into from Mar 4, 2020

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Mar 3, 2020

this picks up work from #82056 and leaves the original author in the first commit.

Fixes #80596

Support TLS Server Name overrides in kubeconfig file and via --tls-server-name in kubectl

surki and others added 2 commits March 3, 2020 12:55
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 3, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 3, 2020
@k8s-ci-robot k8s-ci-robot added area/kubectl sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cli Categorizes an issue or PR as relevant to SIG CLI. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 3, 2020
soltysh
soltysh approved these changes Mar 3, 2020
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold
/assign @tnozicka

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 3, 2020
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 3, 2020
@soltysh
Copy link
Contributor

soltysh commented Mar 3, 2020

/priority backlog
/kind cleanup

@k8s-ci-robot k8s-ci-robot added priority/backlog Higher priority than priority/awaiting-more-evidence. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Mar 3, 2020
@deads2k
Copy link
Contributor Author

deads2k commented Mar 3, 2020

/lgtm
/hold
/assign @tnozicka

Being held for additional time for comments, nothing untoward.

@fedebongio
Copy link
Contributor

/cc @liggitt @mikedanese

@fedebongio
Copy link
Contributor

/sig auth

@k8s-ci-robot k8s-ci-robot added the sig/auth Categorizes an issue or PR as relevant to SIG Auth. label Mar 3, 2020
@liggitt
Copy link
Member

liggitt commented Mar 4, 2020

This resolved my outstanding comments on the original PR.

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 4, 2020
@liggitt liggitt mentioned this pull request Mar 4, 2020
Closed
@k8s-ci-robot k8s-ci-robot merged commit bd6640a into kubernetes:master Mar 4, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Mar 4, 2020
tnozicka
tnozicka reviewed Mar 4, 2020
View reviewed changes
Copy link
Contributor

@tnozicka tnozicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
thanks @deads2k

@tnozicka tnozicka mentioned this pull request Mar 4, 2020
Closed
wking pushed a commit to wking/kubernetes that referenced this pull request Jul 21, 2020
@k8s-publishing-bot
Merge pull request kubernetes#88769 from deads2k/SNI
d5eaf93 
Support TLS Server Name overrides in kubeconfig file

Kubernetes-commit: bd6640a
@klizhentas klizhentas mentioned this pull request Nov 28, 2020
Closed
This was referenced Feb 22, 2023
Merged
Merged
This was referenced Apr 27, 2023
Closed
Merged
k8s-ci-robot pushed a commit to kubernetes-client/csharp that referenced this pull request Apr 28, 2023
@cb
Support TLS Server Name overrides in kubeconfig (#1282)
d8da943 
The client should support tls-server-name just like client-go and kubectl.  See kubernetes/kubernetes#88769
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tnozicka tnozicka tnozicka left review comments

@soltysh soltysh soltysh approved these changes

@dixudx dixudx Awaiting requested review from dixudx

@lavalamp lavalamp Awaiting requested review from lavalamp

@liggitt liggitt Awaiting requested review from liggitt

@mikedanese mikedanese Awaiting requested review from mikedanese

Assignees

@soltysh soltysh

@tnozicka tnozicka

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.

Support TLS Server Name overrides in kubeconfig file
7 participants
@deads2k @k8s-ci-robot @soltysh @fedebongio @liggitt @tnozicka @surki