Capture conformance Behaviors in walk.go #88770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
Jefftree
force-pushed
the
bdd-capture-behaviors
branch
from
e3995c2
to
4ebf9a5
Compare
k8s-ci-robot
added
size/M
Jefftree
force-pushed
the
bdd-capture-behaviors
branch
from
4ebf9a5
to
f2a8d98
Compare
oomichi
reviewed
Mar 4, 2020
Jefftree
force-pushed
the
bdd-capture-behaviors
branch
from
f2a8d98
to
794f04a
Compare
Jefftree
force-pushed
the
bdd-capture-behaviors
branch
from
794f04a
to
6da6380
Compare
k8s-ci-robot
added
size/L
Jefftree
changed the title
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/retest |
oomichi
reviewed
Mar 6, 2020
| @@ -42,9 +42,8 @@ | |||
| codename: '[k8s.io] Container Runtime blackbox test on terminated container should | |||
| report termination message [LinuxOnly] as empty when pod succeeds and TerminationMessagePolicy | |||
| FallbackToLogsOnError is set [NodeConformance] [Conformance]' | |||
| description: 'Name: Container Runtime, TerminationMessage, from log output of succeeding | |||
There was a problem hiding this comment.
This change seems fine according to the corresponding e2e test code as
kubernetes/test/e2e/common/runtime.go
Line 249 in f52cbea
The old description contained
Name: part also, then the description seemed odd. New one seems correct.
There was a problem hiding this comment.
I submitted a follow up PR for this #88923.
Some conformance headers had "Name" instead of "Testname" and were picked up as part of the description by the tooling.
|
/approve |
1 similar comment
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Jefftree, johnbelamaric, oomichi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Capture conformance behaviors if they are defined in the comments section of a test. I will add the behaviors <-> tests linkage in a follow up PR
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
The
conformance.yamlchange fixes #88918. We were logging comments not part of the Description in the Description section.Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
/assign @johnbelamaric
/priority important-soon