Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ignore gcloud warning in test framework #88805

Merged
merged 1 commit into from Mar 18, 2020
Merged

ignore gcloud warning in test framework #88805

merged 1 commit into from Mar 18, 2020

Conversation

aleksandra-malinowska
Copy link
Contributor

Autoscaling tests with multiple MIGs fail with:

Failed to get group size for group ca-minion-group: ERROR: (gcloud.compute.instance-groups.managed.list-instances) Some requests did not succeed:
- Invalid value for field 'zone': 'WARNING: --filter : operator evaluation is changing for consistency across Google APIs. name=ca-minion-group currently does not match but will match in the near future. Run gcloud topic filters for details.
https://www.googleapis.com/compute/v1/projects/k8s-jkns-gci-autoscaling-migs/zones/us-west1-b'. Must be a match of regex '(?:a-z?)'

https://k8s-testgrid.appspot.com/sig-autoscaling-cluster-autoscaler#gci-gce-autoscaling-migs

/kind failing-test
/priority important-soon
/sig autoscaling

none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 4, 2020
@k8s-ci-robot k8s-ci-robot added area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Mar 4, 2020
@MaciekPytel
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 4, 2020
@aleksandra-malinowska
Copy link
Contributor Author

/retest

3 similar comments
@aleksandra-malinowska
Copy link
Contributor Author

/retest

@aleksandra-malinowska
Copy link
Contributor Author

/retest

@aleksandra-malinowska
Copy link
Contributor Author

/retest

fejta
fejta reviewed Mar 5, 2020
View reviewed changes
Copy link
Contributor

@fejta fejta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aleksandra-malinowska, fejta, MaciekPytel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 5, 2020
@k8s-ci-robot k8s-ci-robot merged commit e5f1048 into kubernetes:master Mar 18, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fejta fejta fejta left review comments

@krzyzacy krzyzacy krzyzacy approved these changes

@MaciekPytel MaciekPytel Awaiting requested review from MaciekPytel

Assignees

@fejta fejta

@MaciekPytel MaciekPytel

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@aleksandra-malinowska @MaciekPytel @k8s-ci-robot @fejta @krzyzacy