New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Checks error for loading audit webhook config to prevent panic #88879
Checks error for loading audit webhook config to prevent panic #88879
Conversation
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
Welcome @JoshVanL! |
Hi @JoshVanL. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoshVanL, liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test pull-kubernetes-e2e-kind |
/priority important-soon |
this is a bug and the trace back with panic does not help. let's fix this in 1.18. /milestone v1.18 |
/retest |
Signed-off-by: JoshVanL vleeuwenjoshua@gmail.com
What type of PR is this?
/kind bug
What this PR does / why we need it:
This PR prevents the apiserver from panicking when failing to load the audit webhook config (i.e. when the ca file cannot be read).
Which issue(s) this PR fixes:
Fixes #88878
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: