Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove framework.go's dependency on e2e node sub fw #88949

Merged
merged 1 commit into from Mar 20, 2020
Merged

Remove framework.go's dependency on e2e node sub fw #88949

merged 1 commit into from Mar 20, 2020

Conversation

gavinfish
Copy link
Contributor

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Refactor framework's methods CreateServiceForSimpleAppWithPods, CreateServiceForSimpleApp into service e2e fw, CreatePodsPerNodeForSimpleApp into node e2e fw. Then it can remove framework.go's dependency on e2e node sub fw.

Which issue(s) this PR fixes:

Xref #81245

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

none

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

none

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/test sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 8, 2020
@gavinfish gavinfish changed the title [WIP] Remove framework.go's dependency on e2e node sub fw Remove framework.go's dependency on e2e node sub fw Mar 8, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 8, 2020
@gavinfish
Copy link
Contributor Author

/assign @andrewsykim
/cc @oomichi

@gavinfish
Copy link
Contributor Author

/retest

@neolit123
Copy link
Member

/approve
/priority backlog

@k8s-ci-robot k8s-ci-robot added priority/backlog Higher priority than priority/awaiting-more-evidence. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 9, 2020
@oomichi
Copy link
Member

oomichi commented Mar 9, 2020

Thanks so much for doing this.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 9, 2020
@oomichi
Copy link
Member

oomichi commented Mar 19, 2020

Please rebase this PR based on the latest master.

/lgtm cancel

@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Mar 19, 2020
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 20, 2020
oomichi
oomichi reviewed Mar 20, 2020
View reviewed changes
Copy link
Member

@oomichi oomichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 20, 2020
@gavinfish
Copy link
Contributor Author

/test pull-kubernetes-e2e-kind-ipv6

@oomichi
Copy link
Member

oomichi commented Mar 20, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gavinfish, neolit123, oomichi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 20, 2020
@k8s-ci-robot k8s-ci-robot merged commit 8a7c682 into kubernetes:master Mar 20, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Mar 20, 2020
@gavinfish gavinfish deleted the remove-node branch March 21, 2020 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oomichi oomichi oomichi left review comments

@dcbw dcbw Awaiting requested review from dcbw

@timothysc timothysc Awaiting requested review from timothysc

Assignees

@oomichi oomichi

@andrewsykim andrewsykim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note-none Denotes a PR that doesn't merit a release note. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@gavinfish @neolit123 @oomichi @k8s-ci-robot @andrewsykim