Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify cached object type in apiserver log #88979

Merged
merged 1 commit into from Mar 21, 2020
Merged

Clarify cached object type in apiserver log #88979

merged 1 commit into from Mar 21, 2020

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Mar 9, 2020

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Clarifies the cached object type in the API server log for custom resources.

Before:

Storage caching is enabled for *unstructured.Unstructured with capacity 100

After:

Storage caching is enabled for apiVersion=example.com/v1, kind=Foo with capacity 100

NONE

/cc @MikeSpreitzer
/sig api-machinery
/priority backlog

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. priority/backlog Higher priority than priority/awaiting-more-evidence. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Mar 9, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver labels Mar 9, 2020
MikeSpreitzer
MikeSpreitzer approved these changes Mar 9, 2020
View reviewed changes
Copy link
Member

@MikeSpreitzer MikeSpreitzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Looks good to me, although it continues a problematic naming convention.

staging/src/k8s.io/apiserver/pkg/registry/generic/registry/storage_factory.go
@@ -88,6 +90,17 @@ func StorageWithCacher(capacity int) generic.StorageDecorator {
}
}

func objectTypeToString(obj runtime.Object) string {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In a language with runtime representations for types, such as go, it is actually confusing to use the name "object type" instead of "example object" when the latter is meant. (This complaint applies to a lot of code --- particularly code that uses the golang type interface{} for the value in question --- not just this change.)

@enj
Copy link
Member

enj commented Mar 9, 2020

/lgtm
/retest
/refresh

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 9, 2020
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@liggitt liggitt added this to the v1.19 milestone Mar 12, 2020
@enj
Copy link
Member

enj commented Mar 19, 2020

/sig api-machinery
/priority backlog

@enj
Copy link
Member

enj commented Mar 19, 2020

/test all

(wake up CI?)

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@liggitt
Copy link
Member Author

liggitt commented Mar 21, 2020

/sig api-machinery

@MikeSpreitzer
Copy link
Member

I don't know what's going on with the sig stuff. At #88979 (comment) the bot added both the needs-sig label and the sig/api-machinery label!

@MikeSpreitzer
Copy link
Member

/remove-sig api-machinery

@k8s-ci-robot k8s-ci-robot removed the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Mar 21, 2020
@MikeSpreitzer
Copy link
Member

/sig api-machinery

@k8s-ci-robot k8s-ci-robot added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Mar 21, 2020
@k8s-ci-robot k8s-ci-robot removed the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Mar 21, 2020
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@enj
Copy link
Member

enj commented Mar 21, 2020

/priority important-longterm

Just trying to kick CI

@k8s-ci-robot k8s-ci-robot added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 21, 2020
@enj
Copy link
Member

enj commented Mar 21, 2020

/priority backlog

@k8s-ci-robot k8s-ci-robot merged commit a19942c into kubernetes:master Mar 21, 2020
@enj
Copy link
Member

enj commented Mar 21, 2020

/remove-priority important-longterm

@k8s-ci-robot k8s-ci-robot removed the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label Mar 21, 2020
@liggitt liggitt deleted the crd-watch-cache branch March 24, 2020 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeSpreitzer MikeSpreitzer MikeSpreitzer approved these changes

Assignees

@enj enj

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@liggitt @k8s-ci-robot @enj @fejta-bot @MikeSpreitzer