Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

client-go: remove openstack auth plugin #89014

Merged
merged 2 commits into from Mar 19, 2020
Merged

client-go: remove openstack auth plugin #89014

merged 2 commits into from Mar 19, 2020

Conversation

enj
Copy link
Member

@enj enj commented Mar 10, 2020 •
edited

The openstack auth plugin was deprecated in v1.11 in favor of the "client-keystone-auth" credential plugin. This change removes the plugin in v1.19 (eight releases seems more than sufficient notice).

Signed-off-by: Monis Khan mok@vmware.com

@kubernetes/sig-auth-pr-reviews
@kubernetes/sig-cli-pr-reviews
@kubernetes/provider-openstack-pr-reviews
@dims @hogepodge @dklyle

/kind cleanup
/kind deprecation
/priority important-longterm
/milestone v1.19
/sig auth
/sig cli
/sig openstack
xref: #64346

The openstack auth plugin has been removed.
Please use the "client-keystone-auth" kubectl/client-go credential plugin instead.
See https://github.com/kubernetes/cloud-provider-openstack/blob/master/docs/using-client-keystone-auth.md for further details.

# kubectl configured to use openstack auth-provider
$ kubectl get ns
error: The openstack auth plugin has been removed.
Please use the "client-keystone-auth" kubectl/client-go credential plugin instead.
See https://github.com/kubernetes/cloud-provider-openstack/blob/master/docs/using-client-keystone-auth.md for further details

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/auth Categorizes an issue or PR as relevant to SIG Auth. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. sig/cli Categorizes an issue or PR as relevant to SIG CLI. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. labels Mar 10, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Mar 10, 2020
@k8s-ci-robot k8s-ci-robot added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 10, 2020
@k8s-ci-robot
Copy link
Contributor

@enj: The label(s) sig/openstack cannot be applied, because the repository doesn't have them

In response to this:

The openstack auth plugin was deprecated in v1.11 in favor of the "client-keystone-auth" credential plugin. This change removes the plugin in v1.19 (eight releases seems more than sufficient notice).

Signed-off-by: Monis Khan mok@vmware.com

@kubernetes/sig-auth-pr-reviews
@kubernetes/sig-cli-pr-reviews
@kubernetes/provider-openstack-pr-reviews
@dims @hogepodge @dklyle

/kind cleanup
/kind deprecation
/priority important-longterm
/milestone v1.19
/sig auth
/sig cli
/sig openstack
xref: #64346

The openstack auth plugin has been removed.
Please use the "client-keystone-auth" kubectl/client-go credential plugin instead.
See https://github.com/kubernetes/cloud-provider-openstack/blob/master/docs/using-client-keystone-auth.md for further details.

$ kubectl get ns
error: The openstack auth plugin has been removed.
Please use the "client-keystone-auth" kubectl/client-go credential plugin instead.
See https://github.com/kubernetes/cloud-provider-openstack/blob/master/docs/using-client-keystone-auth.md for further details.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Mar 10, 2020
@enj
Copy link
Member Author

enj commented Mar 10, 2020

/area openstack

?

@k8s-ci-robot
Copy link
Contributor

@enj: The label(s) area/openstack cannot be applied, because the repository doesn't have them

In response to this:

/area openstack

?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@enj
Copy link
Member Author

enj commented Mar 10, 2020

/area provider/openstack

@k8s-ci-robot k8s-ci-robot added the area/provider/openstack Issues or PRs related to openstack provider label Mar 10, 2020
@dims
Copy link
Member

dims commented Mar 10, 2020

/assign @ramineni @lingxiankong @FengyunPan2

@k8s-ci-robot k8s-ci-robot added area/apiserver area/cloudprovider area/dependency Issues or PRs related to dependency changes area/kubectl sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. labels Mar 10, 2020
liggitt
liggitt reviewed Mar 10, 2020
View reviewed changes
staging/src/k8s.io/client-go/plugin/pkg/client/auth/openstack/openstack_stub.go

func newOpenstackAuthProvider(_ string, _ map[string]string, _ rest.AuthProviderConfigPersister) (rest.AuthProvider, error) {
return nil, errors.New(`The openstack auth plugin has been removed.
Please use the "client-keystone-auth" kubectl/client-go credential plugin instead.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice touch

@liggitt
Copy link
Member

liggitt commented Mar 10, 2020

deprecation timeline, mechanics, and replacement stub lgtm.

will defer to @kubernetes/cloud-provider-openstack-maintainers for lgtm

enj added 2 commits March 10, 2020 22:10
@enj
client-go: remove openstack auth plugin
0beb8ea 
The openstack auth plugin was deprecated in v1.11 in favor of the
"client-keystone-auth" credential plugin.  This change removes the
plugin in v1.19 (eight releases seems more than sufficient notice).

Signed-off-by: Monis Khan <mok@vmware.com>
@enj
client-go: drop github.com/gophercloud/gophercloud dep
7a7bc9b 
Signed-off-by: Monis Khan <mok@vmware.com>
@enj enj force-pushed the enj/i/drop_openstack_cred_plugin branch from dab667e to 7a7bc9b Compare March 11, 2020 02:11
@k8s-ci-robot
Copy link
Contributor

@enj: The label(s) sig/openstack cannot be applied, because the repository doesn't have them

In response to this:

The openstack auth plugin was deprecated in v1.11 in favor of the "client-keystone-auth" credential plugin. This change removes the plugin in v1.19 (eight releases seems more than sufficient notice).

Signed-off-by: Monis Khan mok@vmware.com

@kubernetes/sig-auth-pr-reviews
@kubernetes/sig-cli-pr-reviews
@kubernetes/provider-openstack-pr-reviews
@dims @hogepodge @dklyle

/kind cleanup
/kind deprecation
/priority important-longterm
/milestone v1.19
/sig auth
/sig cli
/sig openstack
xref: #64346

The openstack auth plugin has been removed.
Please use the "client-keystone-auth" kubectl/client-go credential plugin instead.
See https://github.com/kubernetes/cloud-provider-openstack/blob/master/docs/using-client-keystone-auth.md for further details.

# kubectl configured to use openstack auth-provider
$ kubectl get ns
error: The openstack auth plugin has been removed.
Please use the "client-keystone-auth" kubectl/client-go credential plugin instead.
See https://github.com/kubernetes/cloud-provider-openstack/blob/master/docs/using-client-keystone-auth.md for further details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lingxiankong
Copy link

/lgtm

thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 16, 2020
@ramineni
Copy link
Contributor

/lgtm

@liggitt
Copy link
Member

liggitt commented Mar 17, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enj, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 17, 2020
@dims
Copy link
Member

dims commented Mar 18, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit 05134da into kubernetes:master Mar 19, 2020
@liggitt liggitt mentioned this pull request Mar 31, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

@sttts sttts Awaiting requested review from sttts

Assignees

@dims dims

@lingxiankong lingxiankong

@ramineni ramineni

@FengyunPan2 FengyunPan2

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/cloudprovider area/dependency Issues or PRs related to dependency changes area/kubectl area/provider/openstack Issues or PRs related to openstack provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@enj @k8s-ci-robot @dims @liggitt @lingxiankong @ramineni @FengyunPan2