Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move GetPodSecretUpdateTimeout from framework/utils to test/e2e/framework/pod/ #89032

Merged
merged 1 commit into from Mar 19, 2020
Merged

move GetPodSecretUpdateTimeout from framework/utils to test/e2e/framework/pod/ #89032

merged 1 commit into from Mar 19, 2020

Conversation

tanjunchen
Copy link
Member

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Which issue(s) this PR fixes:

ref:#77095

Special notes for your reviewer:

break up and simplify test/e2e/framework/utils.go , make it more common and helpful.
so this move function GetPodSecretUpdateTimeout to test/e2e/framework/pod/

Does this PR introduce a user-facing change?:

None

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

None

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 11, 2020
@tanjunchen tanjunchen changed the title move GetPodSecretUpdateTimeout from framework/utils to framework/pod move GetPodSecretUpdateTimeout from framework/utils to test/e2e/framework/pod/ Mar 11, 2020
@k8s-ci-robot k8s-ci-robot added area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 11, 2020
@tanjunchen
Copy link
Member Author

/priority backlog

@k8s-ci-robot k8s-ci-robot added priority/backlog Higher priority than priority/awaiting-more-evidence. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 11, 2020
@tanjunchen
Copy link
Member Author

/cc @oomichi

alejandrox1
alejandrox1 reviewed Mar 14, 2020
View reviewed changes
Copy link
Contributor

@alejandrox1 alejandrox1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @tanjunchen for finding this!
/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 14, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alejandrox1, tanjunchen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 14, 2020
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@oomichi
Copy link
Member

oomichi commented Mar 17, 2020

Nice work

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit 10d6efa into kubernetes:master Mar 19, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Mar 19, 2020
@tanjunchen tanjunchen deleted the move-GetPodSecretUpdateTimeout branch March 19, 2020 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alejandrox1 alejandrox1 alejandrox1 left review comments

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@timothysc timothysc Awaiting requested review from timothysc

@oomichi oomichi Awaiting requested review from oomichi

Assignees

@oomichi oomichi

@alejandrox1 alejandrox1

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note-none Denotes a PR that doesn't merit a release note. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tanjunchen @k8s-ci-robot @fejta-bot @oomichi @alejandrox1