Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up OWNERS_ALIASES #89047

Merged
merged 1 commit into from Mar 19, 2020
Merged

Clean up OWNERS_ALIASES #89047

merged 1 commit into from Mar 19, 2020

Conversation

mrbobbytables
Copy link
Member

What type of PR is this?
/kind cleanup

What this PR does / why we need it:

Removes non org members and the sunset SIG Cluster Ops / SIG On Prem feature approvers from OWNERS_ALIASES.

Special notes for your reviewer:

SIG Cluster Ops Archive - https://github.com/kubernetes/community/tree/master/archive/sig-cluster-ops
SIG On Prem Archive - https://github.com/kubernetes/community/tree/master/archive/sig-on-premise

Does this PR introduce a user-facing change?:

No

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/sig contributor-experience
/priority important-soon

@mrbobbytables
Clean up OWNERS_ALIASES
2f5828e 
- Removes non org members
- Removes sunset SIG On Prem feature approvers
- Removes sunset SIG Cluster Ops feature approvers
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 11, 2020
mrbobbytables
mrbobbytables commented Mar 11, 2020
View reviewed changes
OWNERS_ALIASES
@@ -483,13 +483,11 @@ aliases:
- dchen1107 # Node
- deads2k # API Machinery
- derekwaynecarr # Node
- dghubble # On Premise
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not currently an org member
ref: https://cs.k8s.io/?q=dghubble&i=fosho&files=&repos=kubernetes/org

OWNERS_ALIASES
@@ -505,7 +503,6 @@ aliases:
- thockin # Network
- timothysc # Cluster Lifecycle, Scheduling
- wojtek-t # Scalability
- zehicle # Cluster Ops
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not currently an org member
ref: https://cs.k8s.io/?q=zehicle&i=fosho&files=&repos=kubernetes/org

@liggitt
Copy link
Member

liggitt commented Mar 11, 2020

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 11, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, mrbobbytables

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 11, 2020
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 29c1bc1 into kubernetes:master Mar 19, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Mar 19, 2020
@mrbobbytables mrbobbytables deleted the update-owners-aliases branch February 14, 2021 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lavalamp lavalamp Awaiting requested review from lavalamp

@liggitt liggitt Awaiting requested review from liggitt

Assignees

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mrbobbytables @liggitt @k8s-ci-robot @fejta-bot