apiextensions: wait for complete discovery endpoint #89145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
sttts
added
priority/important-soon
k8s-ci-robot
removed
the
needs-priority
sttts
added
the
sig/api-machinery
k8s-ci-robot
removed
the
needs-sig
3 tasks
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
sttts
force-pushed
the
sttts-apiextensions-discovery-sync
branch
from
d149a43
to
c76ded2
Compare
k8s-ci-robot
added
the
cncf-cla: yes
sttts
force-pushed
the
sttts-apiextensions-discovery-sync
branch
from
c76ded2
to
99add1a
Compare
deads2k
reviewed
Mar 16, 2020
| } | ||
| return true, nil | ||
| }, stopCh); err != nil { | ||
| utilruntime.HandleError(fmt.Errorf("timed out waiting for discovery endpoint to initialize")) |
There was a problem hiding this comment.
panic on these please. Based on the code it should never happen, but I don't want to ever silently not run this.
There was a problem hiding this comment.
ok, timeout happens only when stopCh closed, so we can simply error
sttts
force-pushed
the
sttts-apiextensions-discovery-sync
branch
from
99add1a
to
34f5737
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/kind bug
The discovery endpoint is driven by an informer. During startup it adds CRDs asynchronously (in contrast to the main handler endpoint which is complete as soon as the lister has synched). As a consequence the discovery endpoint might be incomplete for a short period of time when the server starts up. This PR adds an explicit wait until all CRD version have been added to discovery.