Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

comment cleanup for kube-proxy #89146

Merged
merged 1 commit into from Mar 19, 2020
Merged

comment cleanup for kube-proxy #89146

merged 1 commit into from Mar 19, 2020

Conversation

SataQiu
Copy link
Member

@SataQiu SataQiu commented Mar 16, 2020

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
code cleanup for kube-proxy

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 16, 2020
@k8s-ci-robot k8s-ci-robot added area/ipvs sig/network Categorizes an issue or PR as relevant to SIG Network. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 16, 2020
@aojea
Copy link
Member

aojea commented Mar 16, 2020

nit/question, are the On______Synced descriptions accurate? should they be more descriptive??

 is called once all the initial event handlers were
// called and the state is fully propagated to local cache.

@SataQiu
Copy link
Member Author

SataQiu commented Mar 17, 2020

Thanks @aojea !
I refer to something like this https://github.com/kubernetes/kubernetes/blob/master/pkg/proxy/iptables/proxier.go#L580 、https://github.com/kubernetes/kubernetes/blob/master/pkg/proxy/iptables/proxier.go#L617
Do you have a better idea？

@aojea
Copy link
Member

aojea commented Mar 17, 2020

/lgtm
I didn't realize that those descriptions already exist
/assign @thockin @danwinship

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 17, 2020
danwinship
danwinship reviewed Mar 17, 2020
View reviewed changes
pkg/proxy/userspace/proxier.go Outdated
func (proxier *Proxier) OnServiceDelete(service *v1.Service) {
proxier.serviceChange(service, nil, "OnServiceDelete")
}

// OnServiceSynced is called once all the initial even handlers were
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

evenT handlers

Probably needs to be fixed wherever you copied that from too...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @danwinship
Updated!

@danwinship
Copy link
Contributor

/retitle comment cleanup for kube-proxy

@k8s-ci-robot k8s-ci-robot changed the title code cleanup for kube-proxy comment cleanup for kube-proxy Mar 17, 2020
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 17, 2020
@danwinship
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 17, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danwinship, SataQiu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 17, 2020
@SataQiu
Copy link
Member Author

SataQiu commented Mar 19, 2020

/priority important-longterm

@k8s-ci-robot k8s-ci-robot added the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label Mar 19, 2020
@k8s-ci-robot k8s-ci-robot removed the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Mar 19, 2020
@k8s-ci-robot k8s-ci-robot merged commit 1b3c94b into kubernetes:master Mar 19, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Mar 19, 2020
@SataQiu SataQiu mentioned this pull request Apr 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danwinship danwinship danwinship left review comments

@bowei bowei Awaiting requested review from bowei

Assignees

@danwinship danwinship

@thockin thockin

@aojea aojea

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ipvs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note-none Denotes a PR that doesn't merit a release note. sig/network Categorizes an issue or PR as relevant to SIG Network. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@SataQiu @aojea @danwinship @k8s-ci-robot @thockin