Image promoter: Reenable Windows test image building #89152
Conversation
k8s-ci-robot
added
release-note-none
|
/retest |
k8s-ci-robot
added
the
needs-rebase
claudiubelu
force-pushed
the
image-promoter/reenable-windows
branch
from
db3175f
to
eb1a4f8
Compare
k8s-ci-robot
removed
the
needs-rebase
claudiubelu
force-pushed
the
image-promoter/reenable-windows
branch
from
eb1a4f8
to
291527c
Compare
|
/milestone v1.19 |
|
/retest |
|
/test pull-kubernetes-node-e2e-containerd |
|
/skip pull-kubernetes-node-e2e-containerd |
|
/approve /assign @Katharine @fejta |
k8s-ci-robot
added
the
approved
|
/override pull-kubernetes-node-e2e-containerd |
|
@spiffxp: Overrode contexts on behalf of spiffxp: pull-kubernetes-node-e2e-containerd In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
You mean in the agnhost image, or all of them? Sure, but there those images did not have any OWNER files in them in the first place. Who should the owners be? People who contributed the most to them? And since ~20 images have been centralized into agnhost, I assume that we could add an OWNER file per agnhost subcommand (e.g.: the netexec subcommand OWNERS should be the netxec image OWNERS). In any case, we could do that in a separate PR, if we're going to add an OWNER file for every image. |
|
I do not know anything about these images.
|
Well, I hope this is what you wanted. :) #90062 |
|
@claudiubelu I think you meant to tag @fejta . |
Oups! Sorry, my bad. |
The build times are a bit high for the image builder (~50 minutes), and it will a bit more when Windows support will be added to the other test images. This commit changes the machineType to N1_HIGHCPU_8. Reenables Windows test image building. Added DOCKER_CERT_BASE_PATH (default value: $HOME), which will contain the path where the certificates needed for Remote Docker Connection can be found. If a REMOTE_DOCKER_URL was not set for a particular OS version, exclude that image from the manifest list. This fixes an issue where, if REMOTE_DOCKER_URL was not set for Windows Server 1909, the Windows were completely excluded from the manifest list, including for Windows Server 1809 and 1903 which could have been built and pushed. Sets "test-webserver" as the default CMD for kitten and nautilus. Since they are now based on agnhost, they should be set to run test-webserver to maintain previous behaviour. Bumps the agnhost version to 2.13, as 2.12 has already been promoted. 2.13 will contain Windows support. Adds Windows support for the kitten and nautilus images, so they can promoted together with agnhost (they were not previously promoted). Adds OWNERS files to: agnhost, busybox, kitten, nautilus.
claudiubelu
force-pushed
the
image-promoter/reenable-windows
branch
from
291527c
to
94ffe58
Compare
|
@mkumatag Please give your ok that you are willing to be the approvers for the nautilus and kitten images. |
|
@claudiubelu: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: claudiubelu, fejta, spiffxp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
/kind cleanup
/sig windows
/sig testing
What this PR does / why we need it:
The build times are a bit high for the image builder (~50 minutes), and it will a bit more when Windows support will be added to the other test images. This commit changes the
machineTypetoN1_HIGHCPU_8.Reenables Windows test image building. Added
DOCKER_CERT_BASE_PATH(default value:$HOME), which will contain the path where the certificates needed for Remote Docker Connection can be found.If a
REMOTE_DOCKER_URLwas not set for a particular OS version, exclude that image from themanifest list. This fixes an issue where, if
REMOTE_DOCKER_URLwas not set for Windows Server 1909, the Windows were completely excluded from the manifest list, including for Windows Server 1809 and 1903 which could have been built and pushed.Sets
test-webserveras the default CMD forkittenandnautilus. Since they are now based onagnhost, they should be set to runtest-webserverto maintain previous behaviour.Bumps the
agnhostversion to 2.13, as 2.12 has already been promoted. 2.13 will contain Windows support.Adds Windows support for the
kittenandnautilusimages, so they can promoted together withagnhost(they were not previously promoted).Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: