Restore orphaning check in gc test #89236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
release-note-none
k8s-ci-robot
added
kind/bug
|
/priority critical-urgent |
k8s-ci-robot
added
priority/critical-urgent
k8s-ci-robot
added
area/test
sig/testing
| @@ -461,6 +461,9 @@ func setupRCsPods(t *testing.T, gc *garbagecollector.GarbageCollector, clientSet | |||
| } | |||
| orphan := false | |||
| switch { | |||
| case options.OrphanDependents == nil && options.PropagationPolicy == nil && len(initialFinalizers) == 0: | |||
There was a problem hiding this comment.
what about just moving this to the end of the switch?
There was a problem hiding this comment.
I was trying to keep it in the same location to minimize the logical diff from before
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt, mikedanese The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added a commit
that referenced
this pull request
Mar 19, 2020
…6-upstream-release-1.18 Automated cherry pick of #89236: Restore orphaning check in gc test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
/kind failing-test
/kind flake
What this PR does / why we need it:
Restores orphaning check accidentally removed in https://github.com/kubernetes/kubernetes/pull/88708/files#diff-71e62caa4db77f62b62feb4951fd7ca8L464-L466
Which issue(s) this PR fixes:
Fixes #89021
Does this PR introduce a user-facing change?:
/cc @mikedanese
/sig api-machinery