Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.18] Update to Golang 1.13.9 #89398

Merged
merged 3 commits into from Mar 25, 2020
Merged

[1.18] Update to Golang 1.13.9 #89398

merged 3 commits into from Mar 25, 2020

Conversation

justaugustus
Copy link
Member

@justaugustus justaugustus commented Mar 24, 2020 •
edited

(Cherry pick of #89275)

What type of PR is this?
/kind feature cleanup
/area dependency

What this PR does / why we need it:

  • deps: Update to Golang 1.13.9
  • build: Remove kube-cross image building

Accompanying kube-cross bump: kubernetes/release#1200

/assign @BenTheElder @liggitt @cblecker @dims @listx
/milestone v1.18
cc: @kubernetes/release-team @kubernetes/release-engineering
ref: quarterly updates

Does this PR introduce a user-facing change?:

- deps: Update to Golang 1.13.9
- build: Remove kube-cross image building

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

justaugustus and others added 3 commits March 23, 2020 21:52
@justaugustus
build: Remove kube-cross image building
28a7bb5 
kube-cross image building has moved to k/release/images/build/cross.

Signed-off-by: Stephen Augustus <saugustus@vmware.com>
@justaugustus @ixdy
deps: Update to Golang 1.13.9
374e618 
Signed-off-by: Stephen Augustus <saugustus@vmware.com>
Co-authored-by: Jeff Grafton <jgrafton@google.com>
@justaugustus
build/dependencies: Remove bazel WORKSPACE go_version check
3c1d979 
When supplying the go_download_sdk instead of updating rules_go, the
go_version is removed, so we shouldn't check for it anymore in
hack/verify-external-dependencies-version.sh.

Without this, pull-kubernetes-verify jobs will fail.

Signed-off-by: Stephen Augustus <saugustus@vmware.com>
@k8s-ci-robot k8s-ci-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Mar 24, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Mar 24, 2020
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 24, 2020
@k8s-ci-robot k8s-ci-robot added area/release-eng Issues or PRs related to the Release Engineering subproject area/test sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 24, 2020
@justaugustus justaugustus mentioned this pull request Mar 24, 2020
Merged
@justaugustus justaugustus changed the title Automated cherry pick of #89275 upstream release 1.18 [1.18] Update to Golang 1.13.9 Mar 24, 2020
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. area/dependency Issues or PRs related to dependency changes and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Mar 24, 2020
@liggitt
Copy link
Member

liggitt commented Mar 24, 2020

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 24, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justaugustus, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 24, 2020
@justaugustus justaugustus mentioned this pull request Mar 24, 2020
Closed
25 tasks
@justaugustus
Copy link
Member Author

Explicit hold for post-v1.18.0 merge:
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 24, 2020
This was referenced Mar 24, 2020
Merged
Merged
@justaugustus
Copy link
Member Author

Lifting hold as 1.18.0 is live:
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 25, 2020
@justaugustus justaugustus added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Mar 25, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Mar 25, 2020
@k8s-ci-robot k8s-ci-robot merged commit d5dfb5c into kubernetes:release-1.18 Mar 25, 2020
@lixiaobing1 lixiaobing1 mentioned this pull request Jun 9, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenTheElder BenTheElder Awaiting requested review from BenTheElder

@lavalamp lavalamp Awaiting requested review from lavalamp

Assignees

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes area/release-eng Issues or PRs related to the Release Engineering subproject area/test cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@justaugustus @liggitt @k8s-ci-robot