Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix kubectl explicit local port for service #89401

Merged
merged 2 commits into from Mar 24, 2020
Merged

Fix kubectl explicit local port for service #89401

merged 2 commits into from Mar 24, 2020

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Mar 24, 2020

What type of PR is this?
/kind bug

What this PR does / why we need it:
Kubectl currently ignores the local port when creating a port-forward to a service. This PR fixes this and adds unit tests for preventing this behaviour in the future.

Which issue(s) this PR fixes:
Fixes kubernetes/kubectl#836

Special notes for your reviewer:
Builds on #88950 with review comment #88950 (comment) addressed

Does this PR introduce a user-facing change?:

Fixes v1.18.0-rc.1 regression in `kubectl port-forward` when specifying a local and remote port

/sig cli
/milestone v1.18
/priority important-soon
/kind bug
/cc @mariusziemke

@k8s-ci-robot
Copy link
Contributor

@liggitt: GitHub didn't allow me to request PR reviews from the following users: mariusziemke.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

What type of PR is this?
/kind bug

What this PR does / why we need it:
Kubectl currently ignores the local port when creating a port-forward to a service. This PR fixes this and adds unit tests for preventing this behaviour in the future.

Which issue(s) this PR fixes:
Fixes kubernetes/kubectl#836

Special notes for your reviewer:
Builds on #88950 with review comment #88950 (comment) addressed

Does this PR introduce a user-facing change?:

Fixes v1.18.0-rc.1 regression in `kubectl port-forward` when specifying a local and remote port

/sig cli
/milestone v1.18
/priority important-soon
/kind bug
/cc @mariusziemke

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. sig/cli Categorizes an issue or PR as relevant to SIG CLI. labels Mar 24, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Mar 24, 2020
@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/kubectl and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 24, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 24, 2020
@justaugustus
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 24, 2020
@justaugustus justaugustus mentioned this pull request Mar 24, 2020
Closed
@liggitt liggitt mentioned this pull request Mar 24, 2020
Merged
@alejandrox1
Copy link
Contributor

/test pull-kubernetes-node-e2e-containerd
/test pull-kubernetes-e2e-kind

@alejandrox1
Copy link
Contributor

something is up with kind...
/test pull-kubernetes-e2e-kind

@k8s-ci-robot k8s-ci-robot merged commit 11277d4 into kubernetes:master Mar 24, 2020
@k8s-ci-robot k8s-ci-robot modified the milestones: v1.18, v1.19 Mar 24, 2020
k8s-ci-robot added a commit that referenced this pull request Mar 24, 2020
@k8s-ci-robot
Merge pull request #89402 from liggitt/automated-cherry-pick-of-#8940…
4d552d8 
…1-upstream-release-1.18

Automated cherry pick of #89401: fix kubectl port-forward for services with explicit local
@liggitt liggitt deleted the fix_kubectl_explicit_local_port_for_service branch March 24, 2020 13:58
wking pushed a commit to wking/kubernetes that referenced this pull request Jul 21, 2020
@k8s-publishing-bot
Merge pull request kubernetes#89402 from liggitt/automated-cherry-pic…
1ee29f4 
…k-of-#89401-upstream-release-1.18

Automated cherry pick of kubernetes#89401: fix kubectl port-forward for services with explicit local

Kubernetes-commit: 4d552d8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@justaugustus justaugustus

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.

kubectl port-forward for service with explicit local port broken in v1.18.0-beta.1
4 participants
@liggitt @k8s-ci-robot @justaugustus @alejandrox1