Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #89444 upstream release 1.18 #89449

Merged
merged 1 commit into from Mar 25, 2020
Merged

Automated cherry pick of #89444 upstream release 1.18 #89449

merged 1 commit into from Mar 25, 2020

Conversation

saad-ali
Copy link
Member

This fixes bug with xfs mount failing because of xfs_repair
being called. Fixes kubernetes/utils#141

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind api-change

/kind bug

/kind cleanup
/kind deprecation
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
Fix kubernetes/utils#141
Automated cherry pick of #89444 upstream release 1.18

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:
/sig storage
/priority important-soon

Does this PR introduce a user-facing change?:

Fix bug with xfs_repair from stopping xfs mount

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@gnufied @saad-ali
bump k8s.io/utils package
0630031 
This fixes bug with xfs mount failing because of xfs_repair
being called. Fixes kubernetes/utils#141
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Mar 25, 2020
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. sig/storage Categorizes an issue or PR as relevant to SIG Storage. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 25, 2020
@saad-ali
Copy link
Member Author

/assign @liggitt

@k8s-ci-robot k8s-ci-robot requested review from apelisse, caesarxuchao and a team March 25, 2020 00:15
@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. labels Mar 25, 2020
@dims
Copy link
Member

dims commented Mar 25, 2020

k8s.io/utils changes look good

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 25, 2020
@saad-ali
Copy link
Member Author

/hold
Until #89444 merges

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 25, 2020
@gnufied
Copy link
Member

gnufied commented Mar 25, 2020

/test pull-kubernetes-e2e-gce-100-performance

@liggitt
Copy link
Member

liggitt commented Mar 25, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, liggitt, saad-ali

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 25, 2020
@xing-yang
Copy link
Contributor

/lgtm

@alejandrox1
Copy link
Contributor

/cc @kubernetes/patch-release-team

@xing-yang xing-yang mentioned this pull request Mar 25, 2020
Closed
@xing-yang
Copy link
Contributor

#89444 is merged.

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 25, 2020
@justaugustus justaugustus added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Mar 25, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Mar 25, 2020
@k8s-ci-robot k8s-ci-robot merged commit 8be33ca into kubernetes:release-1.18 Mar 25, 2020
@dims dims mentioned this pull request Mar 25, 2020
Merged
27 tasks
wking pushed a commit to wking/kubernetes that referenced this pull request Jul 21, 2020
@k8s-publishing-bot
Merge pull request kubernetes#89449 from saad-ali/automated-cherry-pi…
6a777c7 
…ck-of-#89444-upstream-release-1.18

Automated cherry pick of kubernetes#89444 upstream release 1.18

Kubernetes-commit: 8be33ca
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apelisse apelisse Awaiting requested review from apelisse

@caesarxuchao caesarxuchao Awaiting requested review from caesarxuchao

Assignees

@dims dims

@liggitt liggitt

@xing-yang xing-yang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/cloudprovider area/dependency Issues or PRs related to dependency changes area/kubectl cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@saad-ali @dims @gnufied @liggitt @k8s-ci-robot @xing-yang @alejandrox1 @justaugustus