New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the bug that update-vendor.sh reports error when grep match failed #89579
Fix the bug that update-vendor.sh reports error when grep match failed #89579
Conversation
/assign @liggitt |
/priority important-soon |
I'm not seeing failures in https://testgrid.k8s.io/presubmits-kubernetes-blocking#pull-kubernetes-dependencies... can you describe where you're seeing problems with this? |
@liggitt I wonder why there is no error in https://testgrid.k8s.io/presubmits-kubernetes-blocking#pull-kubernetes-dependencies.
The error does not interrupt program execution (just some log output), but it is not needed here. |
dbeed9d
to
590f0f3
Compare
Hi @BenTheElder , I think I need your help. |
/cc @BenTheElder |
this matches what is done on line 272 /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt, SataQiu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Fix the bug that update-vendor.sh reports error when grep match failed.
Without this patch, when grep match fails, the script will output:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: