Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.18.1: fix a bug where spn: prefix is unexpectedly added to kubeconfig apiserver-id #89706

Merged
merged 1 commit into from Apr 2, 2020

Conversation

weinong
Copy link
Contributor

@weinong weinong commented Mar 31, 2020

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind api-change
/kind bug
/kind cleanup
/kind deprecation
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
fix a bug where spn: prefix is unexpectedly added to kubeconfig apiserver-id

Which issue(s) this PR fixes:

Fixes #89672

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

kubectl azure authentication: fixed a regression in 1.18.0 where "spn:" prefix was unexpectedly added to the `apiserver-id` configuration in the kubeconfig file

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 31, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @weinong. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/auth Categorizes an issue or PR as relevant to SIG Auth. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 31, 2020
@liggitt
Copy link
Member

liggitt commented Apr 1, 2020

/ok-to-test
/priority critical-urgent
/milestone v1.18

@k8s-ci-robot k8s-ci-robot added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 1, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Apr 1, 2020
@k8s-ci-robot k8s-ci-robot removed the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Apr 1, 2020
@liggitt liggitt changed the title fix a bug where spn: prefix is unexpectedly added to kubeconfig apiserver-id v1.18.1: fix a bug where spn: prefix is unexpectedly added to kubeconfig apiserver-id Apr 1, 2020
@liggitt liggitt requested review from liggitt and removed request for lavalamp April 1, 2020 04:13
@liggitt
Copy link
Member

liggitt commented Apr 1, 2020

/retest
/lgtm
/approve

once this merges, can you open a cherry-pick to the release-1.18 branch?

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 1, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, weinong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 1, 2020
@weinong
Copy link
Contributor Author

weinong commented Apr 1, 2020

/retest

1 similar comment
@weinong
Copy link
Contributor Author

weinong commented Apr 1, 2020

/retest

@k8s-ci-robot k8s-ci-robot merged commit f2e3981 into kubernetes:master Apr 2, 2020
@k8s-ci-robot k8s-ci-robot modified the milestones: v1.18, v1.19 Apr 2, 2020
k8s-ci-robot added a commit that referenced this pull request Apr 4, 2020
…6-upstream-release-1.18

Automated cherry pick of #89706: fix a bug where spn: prefix is unexpectedly added to
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/auth Categorizes an issue or PR as relevant to SIG Auth. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kubectl - Azure AD authentication adds excessive 'spn:' to SPN
3 participants