Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update cri-tools to v1.18.0 #89720

Merged
merged 1 commit into from May 18, 2020
Merged

Update cri-tools to v1.18.0 #89720

merged 1 commit into from May 18, 2020

Conversation

saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented Apr 1, 2020 •
edited

What type of PR is this?

/kind feature

What this PR does / why we need it:

Update cri-tools to the latest version and adapt test scripts.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

cc @feiskyer

Does this PR introduce a user-facing change?:

- Update cri-tools to v1.18.0

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- Release Notes: https://github.com/kubernetes-sigs/cri-tools/releases/tag/v1.18.0

/sig release
/cc @kubernetes/release-engineering

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/release-eng Issues or PRs related to the Release Engineering subproject sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/release Categorizes an issue or PR as relevant to SIG Release. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 1, 2020
@k8s-ci-robot k8s-ci-robot requested review from fejta and pjh April 1, 2020 07:57
@saschagrunert
Copy link
Member Author

/retest

@saschagrunert
Copy link
Member Author

/test pull-kubernetes-kubemark-e2e-gce-big

feiskyer
feiskyer reviewed Apr 1, 2020
View reviewed changes
cluster/gce/windows/k8s-node-setup.psm1 Outdated
-Hash $CRICTL_SHA256 `
-Algorithm SHA256
tar xzvf ${env:NODE_DIR}\crictl.tar.gz
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to set dir to NODE_DIR for tar?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll change that, thank you for the hint 👍

@saschagrunert
Copy link
Member Author

/test pull-kubernetes-e2e-gce

feiskyer
feiskyer approved these changes Apr 3, 2020
View reviewed changes
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 3, 2020
fejta
fejta reviewed Apr 7, 2020
View reviewed changes
Copy link
Contributor

@fejta fejta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@saschagrunert
Copy link
Member Author

saschagrunert commented Apr 17, 2020 •
edited

@justaugustus May I ask you to approve if this is fine? Not sure who has the right set of permissions to move forward with this.

@justaugustus justaugustus mentioned this pull request May 1, 2020
Merged
@BenTheElder
Copy link
Member

you can check who has permissions by clicking through to the OWNERS files in the bot comment 🙃
/assign

@BenTheElder
Copy link
Member

/approve
/lgtm

@BenTheElder
Copy link
Member

/test pull-kubernetes-files-remake

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 2, 2020
@justaugustus
Copy link
Member

Thanks Ben! ❤️

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

1 similar comment
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@justaugustus
Copy link
Member

@mm4tt @shyamjvs @wojtek-t @kubernetes/sig-scalability-bugs -- This is pretty consistently failing on pull-kubernetes-e2e-gce-100-performance. Can you take a look?

/test pull-kubernetes-e2e-gce-100-performance
cc: @kubernetes/ci-signal

@k8s-ci-robot k8s-ci-robot added sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. kind/bug Categorizes issue or PR as related to a bug. labels May 8, 2020
@saschagrunert
Copy link
Member Author

I'm really wondering if it's related to my change 🤔 The build log does not seem to state anything related to a failing cri-tools download or such...

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

1 similar comment
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta
Copy link
Contributor

fejta commented May 8, 2020

/retest

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

2 similar comments
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@BenTheElder
Copy link
Member

/hold
https://prow.k8s.io/pr-history/?org=kubernetes&repo=kubernetes&pr=89720
https://prow.k8s.io/job-history/kubernetes-jenkins/pr-logs/directory/pull-kubernetes-e2e-gce-100-performance

the gce-100-performance job is passing on other PRs but has only failed on this one.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 9, 2020
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 18, 2020
@saschagrunert
Update cri-tools to v1.18.0
4b3e023 
Bump cri-tools to the latest version and update test scripts.

Signed-off-by: Sascha Grunert <sgrunert@suse.com>
@saschagrunert
Copy link
Member Author

Solved the issue, PTAL @BenTheElder

@justaugustus
Copy link
Member

@saschagrunert -- What was the fix?

saschagrunert
saschagrunert commented May 18, 2020
View reviewed changes
cluster/gce/gci/configure.sh
Comment on lines -298 to +299
mv "${KUBE_HOME}/${crictl}" "${KUBE_BIN}/crictl"
chmod a+x "${KUBE_BIN}/crictl"
tar xf "${crictl}"
mv crictl "${KUBE_BIN}/crictl"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@justaugustus this part had to be refactored to just untar the downloaded tarball and move the binary from the correct source location.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
/lgtm
/approve
/hold cancel

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels May 18, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, fejta, justaugustus, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 0f2cccc into kubernetes:master May 18, 2020
@saschagrunert saschagrunert deleted the cri-tools branch May 18, 2020 12:59
@jprzychodzen jprzychodzen mentioned this pull request May 19, 2020
Merged
@github-actions github-actions bot mentioned this pull request May 27, 2020
Closed
@saschagrunert saschagrunert mentioned this pull request May 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justaugustus justaugustus justaugustus left review comments

@fejta fejta fejta left review comments

@feiskyer feiskyer feiskyer approved these changes

@cpanato cpanato cpanato approved these changes

@pjh pjh Awaiting requested review from pjh

Assignees

@justaugustus justaugustus

@feiskyer feiskyer

@BenTheElder BenTheElder

@cpanato cpanato

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/gcp Issues or PRs related to gcp provider area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@saschagrunert @BenTheElder @justaugustus @fejta-bot @feiskyer @fejta @k8s-ci-robot @cpanato