Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove duplicate ipvs check #89867

Merged
merged 1 commit into from Apr 7, 2020
Merged

remove duplicate ipvs check #89867

merged 1 commit into from Apr 7, 2020

Conversation

gongguan
Copy link
Contributor

@gongguan gongguan commented Apr 5, 2020

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
remove duplicate ipvs check

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

None

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/ipvs sig/network Categorizes an issue or PR as relevant to SIG Network. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 5, 2020
@gongguan
Copy link
Contributor Author

gongguan commented Apr 5, 2020 •
edited

duplicate CanUseIPVSProxier
https://github.com/kubernetes/kubernetes/blob/master/cmd/kube-proxy/app/server_others.go#L111
https://github.com/kubernetes/kubernetes/blob/master/cmd/kube-proxy/app/server_others.go#L572

Former is only used to avoid an inappropriate noise, see #61074. IMO we should only check CanUseIPVSProxier once and handle init error as a warning like iptables

@gongguan
Copy link
Contributor Author

gongguan commented Apr 5, 2020

/assign @thockin @andrewsykim

@gongguan
Copy link
Contributor Author

gongguan commented Apr 5, 2020

/test pull-kubernetes-e2e-kind-ipv6

andrewsykim
andrewsykim reviewed Apr 6, 2020
View reviewed changes
cmd/kube-proxy/app/server_others.go Outdated Show resolved Hide resolved
cmd/kube-proxy/app/server_others.go Outdated Show resolved Hide resolved
cmd/kube-proxy/app/server_others.go Outdated Show resolved Hide resolved
@gongguan gongguan force-pushed the ipvs-check branch 2 times, most recently from f6157f8 to 94da0a9 Compare April 7, 2020 14:22
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 7, 2020
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 7, 2020
@gongguan
Copy link
Contributor Author

gongguan commented Apr 7, 2020

/test pull-kubernetes-conformance-kind-ga-only-parallel

andrewsykim
andrewsykim reviewed Apr 7, 2020
View reviewed changes
Copy link
Member

@andrewsykim andrewsykim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one more nit :)

cmd/kube-proxy/app/server_others.go Outdated Show resolved Hide resolved
@andrewsykim
Copy link
Member

/test pull-kubernetes-e2e-gci-gce-ipvs

@gongguan
Copy link
Contributor Author

gongguan commented Apr 7, 2020

/test pull-kubernetes-e2e-gce
/test pull-kubernetes-e2e-gci-gce-ipvs

@andrewsykim
Copy link
Member

Session affinity tests are expected to fail in pull-kubernetes-e2e-gci-gce-ipvs (see #89358)

andrewsykim
andrewsykim reviewed Apr 7, 2020
View reviewed changes
Copy link
Member

@andrewsykim andrewsykim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

Thanks @gongguan

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 7, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewsykim, gongguan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 7, 2020
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot
Copy link
Contributor

@gongguan: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kubernetes-node-e2e-containerd d6ea9d7 link /test pull-kubernetes-node-e2e-containerd
pull-kubernetes-e2e-gci-gce-ipvs d6ea9d7 link /test pull-kubernetes-e2e-gci-gce-ipvs

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot merged commit 5123c3a into kubernetes:master Apr 7, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Apr 7, 2020
@gongguan gongguan deleted the ipvs-check branch April 8, 2020 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewsykim andrewsykim andrewsykim left review comments

@johnbelamaric johnbelamaric Awaiting requested review from johnbelamaric

@m1093782566 m1093782566 Awaiting requested review from m1093782566

Assignees

@thockin thockin

@andrewsykim andrewsykim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ipvs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/network Categorizes an issue or PR as relevant to SIG Network. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@gongguan @andrewsykim @k8s-ci-robot @fejta-bot @thockin