Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Controller]: cidr nil ptr dereference #89870

Merged
merged 1 commit into from Apr 14, 2020
Merged

[Controller]: cidr nil ptr dereference #89870

merged 1 commit into from Apr 14, 2020

Conversation

gaurav1086
Copy link
Contributor

@gaurav1086 gaurav1086 commented Apr 5, 2020 •
edited

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind api-change
kind bug
/kind cleanup
/kind deprecation
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
Possible nil pointer deference
Which issue(s) this PR fixes:

Fixes # segmentation fault

Special notes for your reviewer:
N/A
Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

fix null pointer dereference.

NONE

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Apr 5, 2020
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 5, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @gaurav1086!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @gaurav1086. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 5, 2020
@k8s-ci-robot k8s-ci-robot added sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/network Categorizes an issue or PR as relevant to SIG Network. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 5, 2020
@gaurav1086
Copy link
Contributor Author

Signed the CLA. Thank you.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Apr 5, 2020
@gavinfish
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 6, 2020
@gaurav1086
Copy link
Contributor Author

/test pull-kubernetes-node-e2e-containerd

@gaurav1086
Copy link
Contributor Author

/retest

@k8s-ci-robot
Copy link
Contributor

@gaurav1086: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kubernetes-node-e2e-containerd 4cbdb7b link /test pull-kubernetes-node-e2e-containerd

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@aojea
Copy link
Member

aojea commented Apr 7, 2020

@gaurav1086 please check that you fill correctly the release note field in the description to remove the do-not-merge/release-note-label-needed

/lgtm
/assign @bowei

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Apr 7, 2020
@gaurav1086
Copy link
Contributor Author

gaurav1086 commented Apr 10, 2020 •
edited

@aojea @bowei thoughts ?

@gaurav1086
Copy link
Contributor Author

@aojea @bowei @freehan could you run the retest command again ? Thank you.

@gaurav1086
Copy link
Contributor Author

/test pull-kubernetes-node-e2e-containerd

@gaurav1086
Copy link
Contributor Author

/cc @alculquicondor @ahg-g

@alculquicondor
Copy link
Member

/unassign @ahg-g @alculquicondor

We are not controller owners

@alculquicondor
Copy link
Member

/uncc @ahg-g
/uncc @alculquicondor

@gaurav1086
Copy link
Contributor Author

/cc @robscott @thockin @enj @deads2k

@bowei
Copy link
Member

bowei commented Apr 14, 2020

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bowei, gaurav1086

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 14, 2020
@gaurav1086 gaurav1086 mentioned this pull request Apr 14, 2020
Closed
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 344130a into kubernetes:master Apr 14, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Apr 14, 2020
tklauser added a commit to cilium/cilium that referenced this pull request May 8, 2023
@tklauser
ipam/cidrset: avoid nil dereference in getBeginingAndEndIndices
7c2cc13 
Avoid panic()'ing if a nil cidr is passed to
(*CIDRSet).getBeginingAndEndIndices or any of the methods calling it.

Upstream PR: kubernetes/kubernetes#89870

Signed-off-by: Tobias Klauser <tobias@cilium.io>
tklauser added a commit to tklauser/ipam that referenced this pull request May 8, 2023
@tklauser
cidrset: avoid nil dereference in getBeginingAndEndIndices
d8dad5f 
Avoid panic()'ing if a nil cidr is passed to
(*CIDRSet).getBeginingAndEndIndices or any of the methods calling it.

Upstream PR: kubernetes/kubernetes#89870

Signed-off-by: Tobias Klauser <tobias@cilium.io>
aanm pushed a commit to cilium/ipam that referenced this pull request May 9, 2023
@tklauser @aanm
cidrset: avoid nil dereference in getBeginingAndEndIndices
834ee09 
Avoid panic()'ing if a nil cidr is passed to
(*CIDRSet).getBeginingAndEndIndices or any of the methods calling it.

Upstream PR: kubernetes/kubernetes#89870

Signed-off-by: Tobias Klauser <tobias@cilium.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bowei bowei Awaiting requested review from bowei

@freehan freehan Awaiting requested review from freehan

@deads2k deads2k Awaiting requested review from deads2k

@enj enj Awaiting requested review from enj

@robscott robscott Awaiting requested review from robscott

@thockin thockin Awaiting requested review from thockin

Assignees

@bowei bowei

@aojea aojea

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/network Categorizes an issue or PR as relevant to SIG Network. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@gaurav1086 @k8s-ci-robot @gavinfish @aojea @alculquicondor @bowei @fejta-bot