-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add kind/regression label to the pull request template and group them in an HTML comment #89946
Conversation
/test pull-kubernetes-conformance-kind-ga-only-parallel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @saschagrunert :)
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justaugustus, nikhita, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
.github/PULL_REQUEST_TEMPLATE.md
Outdated
@@ -20,6 +20,7 @@ https://git.k8s.io/community/contributors/devel/sig-release/release.md#issuepr-k | |||
> /kind failing-test | |||
> /kind feature | |||
> /kind flake | |||
> /kind regression |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/hold
As was discussed in the PR introducing this label, I think we'd probably consider regressions to also be bugs, and would want them labeled as such. Adding this label here alongside an "uncomment only one" instruction is confusing.
I'd also like to see more information provided when labeling issues as regressions, specifically:
- reproducer steps against a specific prior release that demonstrated different behavior
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, how would we like to handle it in prow? Do we want to add kind/bug
and kind/regression
if the contributors specifies /kind regression
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would probably group the labels like this:
<!--
Add one of the following kinds:
/kind bug
/kind cleanup
/kind documentation
/kind feature
Optionally add one or more of the following kinds if applicable:
/kind api-change
/kind deprecation
/kind failing-test
/kind flake
/kind regression
-->
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I can change that tomorrow. I think we have to preserve the >
before the kind otherwise prow would have issues in parsing the PR body.
I’ll check if I can enhance the kind parser for that as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To apply @liggitt proposed layout (without the prefix) we have to merge kubernetes/test-infra#17261
@saschagrunert: Adding the "do-not-merge/release-note-label-needed" label and removing any existing "release-note-none" label because there is a "kind/deprecation" label on the PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
/remove-lifecycle stale |
We now add the kind/regression to the PR template. We also put the kinds into an HTML comment, because prow is now able to ignore those entries. Signed-off-by: Sascha Grunert <sgrunert@suse.com>
7512cfb
to
1ee320b
Compare
@justaugustus @liggitt kubernetes/test-infra#17261 is in, prow should now be able to ignore the contents of the HTML comment. Refactored the kinds from the suggestions. PTAL |
/retest |
1 similar comment
/retest |
/lgtm |
What type of PR is this?
/kind documentation
What this PR does / why we need it:
We now add the kind/regression to the PR template. We also put the kinds
into an HTML comment, because prow is now able to ignore those entries.
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
cc @justaugustus @liggitt
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: