Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #89232: Use discovery to test apply all status #90033

Merged
merged 3 commits into from May 9, 2020
Merged

Automated cherry pick of #89232: Use discovery to test apply all status #90033

merged 3 commits into from May 9, 2020

Conversation

apelisse
Copy link
Member

@apelisse apelisse commented Apr 9, 2020 •
edited

Cherry pick of #89232 on release-1.16.

#89232: Use discovery to test apply all status

For details on the cherry pick process, see the cherry pick requests page.

Fix bug where sending a status update completely wipes managedFields for some types.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Apr 9, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Apr 9, 2020
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/test kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 9, 2020
@apelisse
Copy link
Member Author

apelisse commented Apr 9, 2020

cc @liggitt
/sig api-machinery
/kind bug
/priority important-soon

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Apr 9, 2020
@apelisse
Copy link
Member Author

apelisse commented Apr 9, 2020

cc @liggitt
/sig api-machinery
/kind bug
/priority important-soon

@apelisse apelisse force-pushed the automated-cherry-pick-of-#89232-upstream-release-1.16 branch from 9b3046b to 0309d75 Compare April 10, 2020 20:07
@apelisse
Copy link
Member Author

/retest

@apelisse
Copy link
Member Author

/assign @liggitt

@liggitt
Copy link
Member

liggitt commented Apr 30, 2020

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 30, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: apelisse, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 30, 2020
@apelisse
Copy link
Member Author

apelisse commented May 1, 2020

/assign @tpepper

@justaugustus
Copy link
Member

FYI @kubernetes/patch-release-team

@tpepper tpepper added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label May 8, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label May 8, 2020
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 244a7b8 into kubernetes:release-1.16 May 9, 2020
bmwiedemann pushed a commit to bmwiedemann/openSUSE that referenced this pull request Dec 23, 2020
@bmwiedemann
Update python-kubernetes to version 12.0.1 / rev 14 via SR 857126
cf525f5 
https://build.opensuse.org/request/show/857126
by user dirkmueller + dimstar_suse
- update to 12.0.1:
 * Kubernetes API version 1.16.15
  - Resolve regression in metadata.managedFields handling in update/patch requests submitted by older API clients ([#91748](https://github.com/kubernetes/k
  ubernetes/pull/91748), [@apelisse](https://github.com/apelisse)) [SIG API Machinery and Testing]
  - Fix bug where sending a status update completely wipes managedFields for some types. ([#90033](kubernetes/kubernetes#90033), [@
  apelisse](https://github.com/apelisse)) [SIG API Machinery and Testing]
  - The `MutatingWebhookConfiguration` and `ValidatingWebhookConfiguration` APIs have been promoted to `admissionregistration.k8s.io/v1`:
    - `failurePolicy` default changed from `Ignore` to `Fail` for v1
    - `matchPolicy` default changed from `Exact` to `Eq
This was referenced Mar 15, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@mbohlool mbohlool Awaiting requested review from mbohlool

Assignees

@liggitt liggitt

@tpepper tpepper

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.16
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@apelisse @liggitt @k8s-ci-robot @justaugustus @fejta-bot @tpepper