Handling error returned by request.Request.ParseForm()

[rvillablanca]

What type of PR is this?

/kind bug

What this PR does / why we need it:

This PR adds error handling for request.Request.ParseForm() method in http handler for stats for kubelet

Which issue(s) this PR fixes:

Fixes #90085

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[k8s-ci-robot]

@rvillablanca: The label(s) kind/node cannot be applied, because the repository doesn't have them

In response to this:

What type of PR is this?

/kind node

What this PR does / why we need it:

This PR adds error handling in http handler for stats for kubelet

Which issue(s) this PR fixes:

Fixes #90085

Special notes for your reviewer:

NONE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
• Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: login-issues@jira.linuxfoundation.org

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[k8s-ci-robot]

Welcome @rvillablanca!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @rvillablanca. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[rvillablanca]

/assign @tallclair

[mattjmcnaughton]

/ok-to-test

Thanks for your diff! I agree that its useful to handle this error case (and makes this endpoint consistent with the behavior of other endpoints).

Non-blocking request - could we add a unit test executing this failure case? We could also add in a follow up pull request if you prefer.

This lgtm other than my one comment - also, could you please add NONE as a release note?

Thanks and welcome to k8s :)

[rvillablanca]

I don't understand what it is happening, it seems libipmctl is a library for intel optane memories 🤔 . Not sure what I can do to solve this, I am using archlinux but it should not be a problem I think.

[rvillablanca]

@mattjmcnaughton 👍 We are done

[mattjmcnaughton]

/lgtm

Thanks!

[tanjunchen]

@mattjmcnaughton this is what I get when I run it

rodrigo@vivobook:~/go/src/k8s.io/kubernetes (fix/handle-error-parseform)*$ ./hack/update-bazel.sh 
gazelle: /home/rodrigo/go/src/k8s.io/kubernetes/vendor/github.com/google/cadvisor/machine/machine_libipmctl.go: error reading go file: /home/rodrigo/go/src/k8s.io/kubernetes/vendor/github.com/google/cadvisor/machine/machine_libipmctl.go: pkg-config not supported: #cgo pkg-config: libipmctl

see https://github.com/kubernetes/kubernetes/pull/90199/files#diff-fa58360a7125fddab9491c80bb3f1a87R73

[rvillablanca]

Hi @mattjmcnaughton, what is next with this PR ? Who can approve this change ?

[k8s-ci-robot]

@mattjmcnaughton: GitHub didn't allow me to assign the following users: can, approve.

Note that only kubernetes members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @tallclair can approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[mattjmcnaughton]

/assign @tallclair

[tallclair]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rvillablanca, tallclair

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/kubelet/OWNERS [tallclair]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[dims]

/test all

[fejta-bot]

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

[fejta-bot]

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

[rvillablanca]

/retest

[tanjunchen]

/retest

[rvillablanca]

/retest

[fejta-bot]

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

[fejta-bot]

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

[fejta-bot]

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

[fejta-bot]

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

[fejta-bot]

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

[rvillablanca]

/retest

[fejta-bot]

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.