Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #87927: Remove Error log for nil StartTime #90241

Merged
merged 1 commit into from Apr 28, 2020
Merged

Automated cherry pick of #87927: Remove Error log for nil StartTime #90241

merged 1 commit into from Apr 28, 2020

Conversation

alculquicondor
Copy link
Member

@alculquicondor alculquicondor commented Apr 17, 2020 •
edited

Cherry pick of #87927 on release-1.16.

#87927: Remove Error log for nil StartTime

For details on the cherry pick process, see the cherry pick requests page.

Does this PR introduce a user-facing change?:

Pods that are considered for preemption and haven't started don't produce an error log.

@alculquicondor
Remove Error log for nil StartTime
29bcef3 
Signed-off-by: Aldo Culquicondor <acondor@google.com>
@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Apr 17, 2020
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 17, 2020
@alculquicondor
Copy link
Member Author

/sig scheduling
/kind bug
/priority critical-urgent

@k8s-ci-robot k8s-ci-robot added sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. kind/bug Categorizes issue or PR as related to a bug. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 17, 2020
@alculquicondor
Copy link
Member Author

cc @MaciekPytel

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Apr 17, 2020
@ahg-g
Copy link
Member

ahg-g commented Apr 17, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 17, 2020
@alculquicondor
Copy link
Member Author

/retest

@MaciekPytel
Copy link
Contributor

This is really important for cluster-autoscaler, with the way it uses embedded scheduler code this log line can quickly produce gigabytes of useless logs at the error level.

@alculquicondor
Copy link
Member Author

@kubernetes/patch-release-team

@alculquicondor
Copy link
Member Author

ping @kubernetes/patch-release-team

@justaugustus justaugustus added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Apr 28, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Apr 28, 2020
@justaugustus
Copy link
Member

From @MaciekPytel on #sig-release Slack:

Can we somehow prioritize this PR and get it merged faster? We're not as much interested in it being included in patch release as being merged to release-1.16 branch.

Context: this code is vendored by Cluster Autoscaler and it causes a very serious problem where CA produces gigabytes of logs and potentially kills the node it's running on by filling the drive. Cluster Autoscaler has a separate release schedule and we'd like to do a patch release, but we're blocked on the fix being merged, so we can update vendor to a version with the fix.

Note that Cluster Autoscaler works by running scheduler code to predict if adding a new node will make pods schedulable, so it must use vendor the matching version of scheduler (ie. CA 1.16 must vendor release-1.16 and not a newer version of Kubernetes).

@k8s-ci-robot k8s-ci-robot merged commit 9b2f377 into kubernetes:release-1.16 Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@draveness draveness Awaiting requested review from draveness

@resouer resouer Awaiting requested review from resouer

Assignees

@ahg-g ahg-g

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.16
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@alculquicondor @k8s-ci-robot @ahg-g @MaciekPytel @justaugustus