Provider/Azure: Enrich the unit tests for azure_vmss.go. #90273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
|
/priority important-soon |
k8s-ci-robot
added
priority/important-soon
nilo19
changed the title
|
/sig cloud-provider |
k8s-ci-robot
added
sig/cloud-provider
feiskyer
reviewed
Apr 20, 2020
| @@ -712,7 +712,7 @@ func (ss *scaleSet) GetPrimaryInterface(nodeName string) (network.Interface, err | |||
| exists, realErr := checkResourceExistsFromError(rerr) | |||
| if realErr != nil { | |||
| klog.Errorf("error: ss.GetPrimaryInterface(%s), ss.GetVirtualMachineScaleSetNetworkInterface.Get(%s, %s, %s), err=%v", nodeName, resourceGroup, ssName, nicName, realErr) | |||
| return network.Interface{}, err | |||
| return network.Interface{}, realErr.Error() | |||
There was a problem hiding this comment.
thanks for fixing the bug here
feiskyer
reviewed
Apr 20, 2020
| VirtualMachineScaleSetIPConfigurationProperties: &compute.VirtualMachineScaleSetIPConfigurationProperties{}, | ||
| VirtualMachineScaleSetIPConfigurationProperties: &compute.VirtualMachineScaleSetIPConfigurationProperties{ | ||
| Primary: to.BoolPtr(true), | ||
| LoadBalancerBackendAddressPools: &[]compute.SubResource{{ID: to.StringPtr("/subscriptions/sub/resourceGroups/rg/providers/Microsoft.Network/loadBalancers/lb/backendAddressPools/backendpool-0")}}, |
There was a problem hiding this comment.
nit: define a const for LoadBalancerBackendAddressPoolId
feiskyer
reviewed
Apr 20, 2020
| @@ -106,12 +116,16 @@ func buildTestVirtualMachineEnv(ss *Cloud, scaleSetName, zone string, faultDomai | |||
| }, | |||
| InstanceView: &compute.VirtualMachineScaleSetVMInstanceView{ | |||
| PlatformFaultDomain: &faultDomain, | |||
| Statuses: &[]compute.InstanceViewStatus{ | |||
| {Code: to.StringPtr("PowerState/Running")}, | |||
There was a problem hiding this comment.
same here, define a const for power state
nilo19
force-pushed
the
cleanup/enrich-azure-vmss-unit-test
branch
from
d66a383
to
3fdceba
Compare
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: feiskyer, nilo19 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
Hey @nilo19, may I ask here too to change the PR release notes block to just |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Enrich the unit tests for azure_vmss.go. The test coverage increases from 19.7% to 82.9%.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: