Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deflake TCP Closewait e2e test #90278

Merged
merged 3 commits into from Apr 21, 2020
Merged

Deflake TCP Closewait e2e test #90278

merged 3 commits into from Apr 21, 2020

Conversation

aojea
Copy link
Member

@aojea aojea commented Apr 19, 2020 •
edited

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind api-change
/kind bug
/kind cleanup
/kind deprecation
/kind design
/kind documentation
/kind failing-test
/kind feature

/kind flake

What this PR does / why we need it:

Several tweaks to this flake test:

  • Don't pull the images always
  • Increase the termination grace period
  • Increase the timeout holding the TCP connection in the close_wait status
  • Poll every 1 second instead of 5 seconds
  • Don't close the connection if there is no data, we are not sending data and make the test racy

Which issue(s) this PR fixes:

Fixes #

It should fix #71565 :-)
Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@aojea
e2e kube_proxy pull only if not available
638e077
@aojea
e2e kube-proxy don't delete inmediatly
4b423ad
@aojea
e2e TCP Close-wait don't set conn deadline
6efe6e1 
Don't set a connection deadline for reading, because the read operation will
fail if no data is reaceived after the deadline, and will not keep the
connection in the close_wait status.
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/flake Categorizes issue or PR as related to a flaky test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 19, 2020
@k8s-ci-robot k8s-ci-robot added area/test sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 19, 2020
@aojea
Copy link
Member Author

aojea commented Apr 19, 2020

/hold
until we have more or 10 runs succesful

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 19, 2020
@aojea aojea changed the title Closewait Deflake TCP Closewait e2e test Apr 19, 2020
@aojea
Copy link
Member Author

aojea commented Apr 19, 2020

/test pull-kubernetes-node-e2e

@aojea
Copy link
Member Author

aojea commented Apr 19, 2020

uppps is
/test pull-kubernetes-e2e-gce

@aojea
Copy link
Member Author

aojea commented Apr 19, 2020

unrelated failure,
/retest

@aojea
Copy link
Member Author

aojea commented Apr 19, 2020

/test pull-kubernetes-e2e-gce

unrelated failure:

[sig-apps] ReplicationController should test the lifecycle of a ReplicationController expand_less

@aojea
Copy link
Member Author

aojea commented Apr 19, 2020

/test pull-kubernetes-e2e-gce

1 similar comment
@aojea
Copy link
Member Author

aojea commented Apr 19, 2020

/test pull-kubernetes-e2e-gce

@aojea
Copy link
Member Author

aojea commented Apr 19, 2020

/hold cancel
/assign @BenTheElder @spiffxp

This should make the test more resilient per the reasons I've added to the description
🤞

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 19, 2020
@aojea
Copy link
Member Author

aojea commented Apr 19, 2020

/priority important-soon

@k8s-ci-robot k8s-ci-robot added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Apr 19, 2020
@k8s-ci-robot k8s-ci-robot removed the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Apr 19, 2020
@aojea
Copy link
Member Author

aojea commented Apr 20, 2020

/test pull-kubernetes-e2e-gce

@spiffxp
Copy link
Member

spiffxp commented Apr 20, 2020

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 20, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 20, 2020
@k8s-ci-robot k8s-ci-robot merged commit d6f44b0 into kubernetes:master Apr 21, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Apr 21, 2020
@spiffxp spiffxp mentioned this pull request Apr 22, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caseydavenport caseydavenport Awaiting requested review from caseydavenport

@dcbw dcbw Awaiting requested review from dcbw

Assignees

@spiffxp spiffxp

@BenTheElder BenTheElder

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/flake Categorizes issue or PR as related to a flaky test. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.

Flake: [sig-network] Network should set TCP CLOSE_WAIT timeout
4 participants
@aojea @spiffxp @k8s-ci-robot @BenTheElder