New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kubeadm: do not use /bin/sleep during upgrade pre-pull #90320
kubeadm: do not use /bin/sleep during upgrade pre-pull #90320
Conversation
/kind feature |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: neolit123 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold opened separate issue about a related problem here |
for the discussion whether we should not use a DS let's continue here: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a big improvement over /bin/sleep 3600
!
/lgtm
/test pull-kubernetes-e2e-kind-ipv6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
/lgtm
/test pull-kubernetes-e2e-kind
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for tackling this @neolit123 !
My general feeling here is that we should nuke the DaemonSet pre-puller and stick to the pre-flight check based one during upgrade (as we do in init/join).
a772cb9
to
1ca4272
Compare
@rosti i've updated the PR after our discussion with @fabriziopandini /hold cancel |
Use an init container that performs the pre-pull of a component and then start an instance of "pause" as a regular container to get the DaemonSet Pod in a Running state. More details on this change in the code comments.
1ca4272
to
425552f
Compare
/test pull-kubernetes-e2e-kind |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @neolit123 !
/lgtm
/retest Review the full test history for this PR. Silence the bot with an |
What this PR does / why we need it:
Use an init container that performs the pre-pull of a component
and then start an instance of "pause" as a regular container to
get the DaemonSet Pod in a Running state.
More details on this change in the code comments.
Which issue(s) this PR fixes:
Fixes kubernetes/kubeadm#1862
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: