Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #89222: bugfix: initcontainer wasn't considered when calculate #90378

Merged
merged 1 commit into from Apr 30, 2020
Merged

Automated cherry pick of #89222: bugfix: initcontainer wasn't considered when calculate #90378

merged 1 commit into from Apr 30, 2020

Conversation

alculquicondor
Copy link
Member

@alculquicondor alculquicondor commented Apr 22, 2020 •
edited

Cherry pick of #89222 on release-1.18.

#89222: bugfix: initcontainer wasn't considered when calculate

/kind bug
/priority critical-urgent

Fix: Init containers are now considered for the calculation of resource requests when scheduling

For details on the cherry pick process, see the cherry pick requests page.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Apr 22, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Apr 22, 2020
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 22, 2020
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Apr 22, 2020
@alculquicondor
Copy link
Member Author

/assign @Huang-Wei

Huang-Wei
Huang-Wei reviewed Apr 23, 2020
View reviewed changes
Copy link
Member

@Huang-Wei Huang-Wei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 23, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, Huang-Wei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@alculquicondor
Copy link
Member Author

@kubernetes/patch-release-team PTAL

@alculquicondor alculquicondor mentioned this pull request Apr 23, 2020
Merged
@tpepper tpepper added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Apr 28, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Apr 28, 2020
k8s-ci-robot added a commit that referenced this pull request Apr 28, 2020
@k8s-ci-robot
Merge pull request #90414 from alculquicondor/automated-cherry-pick-o…
6de1b37 
…f-#90378-upstream-release-1.17

Automated cherry pick of #90378: bugfix: initcontainer wasn't considered when calculate
@alculquicondor
Copy link
Member Author

/sig scheduling

@alculquicondor
Copy link
Member Author

/remove-sig scheduling

@k8s-ci-robot k8s-ci-robot removed sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 30, 2020
@alculquicondor
Copy link
Member Author

/sig scheduling

@k8s-ci-robot k8s-ci-robot added the sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. label Apr 30, 2020
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 058eecb into kubernetes:release-1.18 Apr 30, 2020
This was referenced May 14, 2020
Merged
Closed
@aermakov-zalando aermakov-zalando mentioned this pull request Jun 15, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Huang-Wei Huang-Wei Huang-Wei left review comments

@damemi damemi Awaiting requested review from damemi

Assignees

@Huang-Wei Huang-Wei

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@alculquicondor @k8s-ci-robot @fejta-bot @Huang-Wei @tpepper @fengzixu