Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #90378: bugfix: initcontainer wasn't considered when calculate #90414

Merged
merged 1 commit into from Apr 28, 2020
Merged

Automated cherry pick of #90378: bugfix: initcontainer wasn't considered when calculate #90414

merged 1 commit into from Apr 28, 2020

Conversation

alculquicondor
Copy link
Member

@alculquicondor alculquicondor commented Apr 23, 2020 •
edited

Cherry pick of #90378 on release-1.17.

#90378: bugfix: initcontainer wasn't considered when calculate

/kind bug
/priority critical-urgent

Fix: Init containers are now considered for the calculation of resource requests when scheduling

For details on the cherry pick process, see the cherry pick requests page.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Apr 23, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Apr 23, 2020
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 23, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 23, 2020
@alculquicondor alculquicondor force-pushed the automated-cherry-pick-of-#90378-upstream-release-1.17 branch from 38e0f39 to 4b08df6 Compare April 23, 2020 19:20
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 23, 2020
@fengzixu @alculquicondor
bugfix: initcontainer wasn't considered when calculate resource request
a1c8cd8 
Signed-off-by: Aldo Culquicondor <acondor@google.com>
@alculquicondor alculquicondor force-pushed the automated-cherry-pick-of-#90378-upstream-release-1.17 branch from 4b08df6 to a1c8cd8 Compare April 23, 2020 19:33
@alculquicondor
Copy link
Member Author

/assign @Huang-Wei

@Huang-Wei
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 24, 2020
@alculquicondor
Copy link
Member Author

@kubernetes/patch-release-team

@alculquicondor alculquicondor mentioned this pull request Apr 24, 2020
Merged
@tpepper tpepper added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Apr 28, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Apr 28, 2020
k8s-ci-robot added a commit that referenced this pull request Apr 28, 2020
@k8s-ci-robot
Merge pull request #90455 from alculquicondor/automated-cherry-pick-o…
3730614 
…f-#90414-upstream-release-1.16

Automated cherry pick of #90414: bugfix: initcontainer wasn't considered when calculate
@k8s-ci-robot k8s-ci-robot merged commit 6de1b37 into kubernetes:release-1.17 Apr 28, 2020
@aermakov-zalando aermakov-zalando mentioned this pull request Jun 15, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hex108 hex108 Awaiting requested review from hex108

@k82cn k82cn Awaiting requested review from k82cn

Assignees

@Huang-Wei Huang-Wei

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.17
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@alculquicondor @k8s-ci-robot @Huang-Wei @tpepper @fengzixu